Ticket #5319: mythtv-5319-require_same_time_zone_settings_on_sbe_and_frontends.patch

libs/libmythdb/exitcodes.h

@@ -10 +10 @@
 #define GENERIC_EXIT_DB_ERROR                     250
 #define GENERIC_EXIT_SOCKET_ERROR                 249
 #define GENERIC_EXIT_OPENING_LOGFILE_ERROR        248
-#define GENERIC_EXIT_UNKNOWN_ERROR                247
-#define GENERIC_EXIT_EXECL_ERROR                  246
-#define FIXME_BUG__LIBRARY_EXIT_NO_THEME          245
-#define FIXME_BUG__LIBRARY_EXIT_TFW_FAILED_OPEN   244
-#define GENERIC_EXIT_START                        244
+#define GENERIC_EXIT_INVALID_TIMEZONE             247
+#define GENERIC_EXIT_UNKNOWN_ERROR                246
+#define GENERIC_EXIT_EXECL_ERROR                  245
+#define FIXME_BUG__LIBRARY_EXIT_NO_THEME          244
+#define FIXME_BUG__LIBRARY_EXIT_TFW_FAILED_OPEN   243
+#define GENERIC_EXIT_START                        243
 #define GENERIC_EXIT_CMD_NOT_FOUND                127
 
 // libmyth
@@ -33 +34 @@
 #define FRONTEND_EXIT_DB_OUTOFDATE                GENERIC_EXIT_DB_OUTOFDATE
 #define FRONTEND_EXIT_DB_ERROR                    GENERIC_EXIT_DB_ERROR
 
+#define FRONTEND_EXIT_INVALID_TIMEZONE            GENERIC_EXIT_INVALID_TIMEZONE
 #define FRONTEND_BUGGY_EXIT_NO_THEME              GENERIC_EXIT_NO_THEME
 #define FRONTEND_BUGGY_EXIT_NO_SELECTOR           GENERIC_EXIT_START-1
 #define FRONTEND_EXIT_START                       GENERIC_EXIT_START-1
@@ -42 +44 @@
 #define BACKEND_EXIT_NO_MYTHCONTEXT               GENERIC_EXIT_NO_MYTHCONTEXT
 #define BACKEND_EXIT_INVALID_CMDLINE              GENERIC_EXIT_INVALID_CMDLINE
 #define BACKEND_EXIT_DB_OUTOFDATE                 GENERIC_EXIT_DB_OUTOFDATE
+#define BACKEND_EXIT_INVALID_TIMEZONE             GENERIC_EXIT_INVALID_TIMEZONE
 #define BACKEND_EXIT_OPENING_LOGFILE_ERROR        GENERIC_EXIT_OPENING_LOGFILE_ERROR
 #define BACKEND_EXIT_NO_CONNECT                   GENERIC_EXIT_START-1
 #define BACKEND_EXIT_NO_IP_ADDRESS                GENERIC_EXIT_START-2

programs/mythbackend/main.cpp

@@ -782 +782 @@
         }
     }
 
+    if (!checkTimeZone())
+    {
+        // Check for different time zones, different offsets, different times
+        VERBOSE(VB_IMPORTANT, "The time and/or time zone settings on this "
+                "system do not match those in use on the master backend. "
+                "Please ensure all frontend and backend systems are "
+                "configured to use the same time zone and have the current "
+                "time properly set.");
+        VERBOSE(VB_IMPORTANT, "Unable to run with invalid time settings. "
+                              "Exiting.");
+        return BACKEND_EXIT_INVALID_TIMEZONE;
+    }
     if (!UpgradeTVDatabaseSchema(true, true))
     {
         VERBOSE(VB_IMPORTANT, "Couldn't upgrade database to new schema");

programs/mythfrontend/main.cpp

@@ -1301 +1301 @@
     }
     setuid(getuid());
 
+    if (!checkTimeZone())
+    {
+        // Check for different time zones, different offsets, different times
+        VERBOSE(VB_IMPORTANT, "The time and/or time zone settings on this "
+                "system do not match those in use on the master backend. "
+                "Please ensure all frontend and backend systems are "
+                "configured to use the same time zone and have the current "
+                "time properly set.");
+        VERBOSE(VB_IMPORTANT, "Unable to run with invalid time settings. "
+                              "Exiting.");
+        return FRONTEND_EXIT_INVALID_TIMEZONE;
+    }
     if (!UpgradeTVDatabaseSchema(upgradeAllowed))
     {
         VERBOSE(VB_IMPORTANT,

libs/libmyth/util.cpp

@@ -349 +349 @@
     return zone_id;
 }
 
+/** \fn checkTimeZone()
+ *  \brief Verifies the time zone settings on this system agree with those
+ *         on the master backend
+ */
+bool checkTimeZone(void)
+{
+    if (gContext->IsMasterBackend())
+        return true;
+
+    QStringList master_settings(QString("QUERY_TIME_ZONE"));
+    if (!gContext->SendReceiveStringList(master_settings))
+    {
+        VERBOSE(VB_IMPORTANT, "Unable to determine master backend time zone "
+                              "settings.  If those settings differ from local "
+                              "settings, some functionality will fail.");
+        return true;
+    }
+
+    bool have_zone_IDs = true;
+    QString master_time_zone_ID = master_settings[0];
+    QString master_utc_offset = master_settings[1];
+    QString master_time_string = master_settings[2];
+    QString local_time_zone_ID = getTimeZoneID();
+    QString local_utc_offset = format_utc_offset();
+    QDateTime local_time = mythCurrentDateTime();
+
+    if (master_time_zone_ID == "UNDEF")
+    {
+        VERBOSE(VB_IMPORTANT, "Unable to determine master backend time zone "
+                              "settings. If local time zone settings differ "
+                              "from master backend settings, some "
+                              "functionality will fail.");
+        have_zone_IDs = false;
+    }
+    if (local_time_zone_ID == "UNDEF")
+    {
+        VERBOSE(VB_IMPORTANT, "Unable to determine local time zone settings. "
+                              "If local time zone settings differ from "
+                              "master backend settings, some functionality "
+                              "will fail.");
+        have_zone_IDs = false;
+    }
+
+    if (have_zone_IDs && (master_time_zone_ID != local_time_zone_ID))
+    {
+        VERBOSE(VB_IMPORTANT, "Time zone settings on the master backend "
+                              "differ from those on this system.");
+        VERBOSE(VB_IMPORTANT, QString("Detected time zone settings:\n"
+                "Zone ID: Master: '%1'. Local: '%2'.\n"
+                "UTC Offset: Master: '%3'. Local: '%4'.\n"
+                "Current Time: Master: '%5'. Local: '%6'")
+                .arg(master_time_zone_ID).arg(local_time_zone_ID)
+                .arg(master_utc_offset).arg(local_utc_offset)
+                .arg(master_time_string).arg(local_time.toString(Qt::ISODate)));
+        return false;
+    }
+
+    // Verify offset
+    if (master_utc_offset == "UNDEF")
+    {
+        VERBOSE(VB_IMPORTANT, "Unable to determine master backend UTC "
+                              "offset. If local time zone settings differ "
+                              "from master backend settings, some "
+                              "functionality will fail.");
+    }
+    else if (master_utc_offset != local_utc_offset)
+    {
+        VERBOSE(VB_IMPORTANT, "UTC offset on the master backend differs "
+                              "from offset on this system.");
+        VERBOSE(VB_IMPORTANT, QString("Detected time zone settings:\n"
+                "Zone ID: Master: '%1'. Local: '%2'.\n"
+                "UTC Offset: Master: '%3'. Local: '%4'.\n"
+                "Current Time: Master: '%5'. Local: '%6'")
+                .arg(master_time_zone_ID).arg(local_time_zone_ID)
+                .arg(master_utc_offset).arg(local_utc_offset)
+                .arg(master_time_string).arg(local_time.toString(Qt::ISODate)));
+        return false;
+    }
+
+    // Verify current time
+    if (master_time_string == "UNDEF")
+    {
+        VERBOSE(VB_IMPORTANT, "Unable to determine current time on the master "
+                              "backend . If local time or time zone settings "
+                              "differ from those on the master backend, some "
+                              "functionality will fail.");
+    }
+    else
+    {
+        QDateTime master_time = QDateTime::fromString(master_time_string,
+                                                      Qt::ISODate);
+        if (abs(master_time.secsTo(local_time)) > 300)
+        {
+            VERBOSE(VB_IMPORTANT, "Current time on the master backend "
+                                  "differs from time on this system.");
+            VERBOSE(VB_IMPORTANT, QString("Detected time zone settings:\n"
+                    "Zone ID: Master: '%1'. Local: '%2'.\n"
+                    "UTC Offset: Master: '%3'. Local: '%4'.\n"
+                    "Current Time: Master: '%5'. Local: '%6'")
+                    .arg(master_time_zone_ID).arg(local_time_zone_ID)
+                    .arg(master_utc_offset).arg(local_utc_offset)
+                    .arg(master_time_string)
+                    .arg(local_time.toString(Qt::ISODate)));
+            return false;
+        }
+    }
+
+    return true;
+}
+
 /** \fn encodeLongLong(QStringList&,long long)
  *  \brief Encodes a long for streaming in the MythTV protocol.
  *

libs/libmyth/util.h

@@ -26 +26 @@
 MPUBLIC int calc_utc_offset(void);
 MPUBLIC QString format_utc_offset(void);
 MPUBLIC QString getTimeZoneID(void);
+MPUBLIC bool checkTimeZone(void);
 
 // This is necessary for GCC 3.3, which has llabs(long long)
 // but not abs(long long) or std::llabs(long long)