Opened 18 years ago

Closed 18 years ago

#1315 closed defect (fixed)

Move Bookmarks & Cutlist to Recordedmarkup

Reported by: stuart@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

Attached patch moves bookmarks and cutlists to the recorded markup table. It also takes advantage of the MarkupMap? methods to simplify the code.

It *should* preserve current cutlists and bookmarks.

There are a few schema changes related to this and a new column has been added to recordedmarkup in preparation for adding markers with custom labels.

Attachments (2)

bookmark_cutlist_move.diff​ (11.9 KB) - added by stuart@… 18 years ago.
bookmark_cutlist_move_2.diff​ (11.7 KB) - added by stuart@… 18 years ago.
Updated patch. Removes some unnecessary changes and applies cleanly to current SVN.

Download all attachments as: .zip

Change History (8)

Changed 18 years ago by stuart@…

Attachment: bookmark_cutlist_move.diff​ added

comment:1 Changed 18 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

Changed 18 years ago by stuart@…

Attachment: bookmark_cutlist_move_2.diff​ added

Updated patch. Removes some unnecessary changes and applies cleanly to current SVN.

comment:2 Changed 18 years ago by anonymous

Updated patch to apply cleanly to SVN. There are also a couple of changes, in particular one DB alteration has been removed as the next step of splitting seek info and markup into seperate tables makes the extra table column redundant.

comment:3 Changed 18 years ago by cpinkham

Status: new → assigned

comment:4 Changed 18 years ago by cpinkham

Resolution: → fixed
Status: assigned → closed

(In [9270]) Move the cutlist and bookmark values into the recordedmarkup table. This is part of some bigger changes that Stuart is working on with regards to the recordedmarkup table to put markups into one table and seektable information into another.

Closes #1315.

comment:5 Changed 18 years ago by jppoet@…

Resolution: fixed
Severity: medium → high
Status: closed → reopened
Type: patch → defect

Typo in dbcheck.cpp, line 2065:

query.prepare("SELECT chanid, startime, cutlist FROM recorded"

" WHERE LENGTH(cutlist) > 1;");

startime should be starttime.

comment:6 Changed 18 years ago by cpinkham

Resolution: → fixed
Status: reopened → closed

(In [9307]) Fix a bug in converting the cutlist to use the recordedmarkup table that was introduced in [9270]. Closes #1315.

Note: See TracTickets for help on using tickets.