Opened 18 years ago

Closed 15 years ago

Last modified 15 years ago

#1607 closed patch (wontfix)

mtd cleanup / autocrop prep.

Reported by: mcheely@… Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: mythvideo Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

This patch cleans up the mtd a little bit. Transcode parameters and DVD characteristics are now member variables of DVDTranscodeThread. buildTranscodeCommandLine() doesn't end up querying the database twice in two-pass mode (or at all). GetTranscodeParams?() queries the database once early in DVDTranscodeThread::run().

Transcode parameters can now be changed in the middle of a job for things like autocropping, and will be persistant across runs in two-pass encoding. Also, buildTranscodeCommandLine() is called in the same place for both passes, making the code ever so slightly less confusing.

Attachments (1)

mtd_cleanup.patch​ (10.1 KB) - added by mcheely@… 18 years ago.

Download all attachments as: .zip

Change History (11)

Changed 18 years ago by mcheely@…

Attachment: mtd_cleanup.patch​ added

comment:1 Changed 18 years ago by mcheely@…

Owner: changed from Isaac Richards to Anduin Withers

I always forget something

comment:2 Changed 18 years ago by Anduin Withers

Milestone: → 0.21

comment:3 Changed 17 years ago by Anduin Withers

Component: mythdvd → mythvideo

comment:4 Changed 16 years ago by Anduin Withers

Milestone: 0.21 → 0.22

comment:5 Changed 16 years ago by danielk

Version: → head

comment:6 Changed 15 years ago by Dibblah

Status: new → infoneeded_new

This patch no longer applies to trunk, even when taking into account that mythdvd is now mythvideo. Is this still required?

comment:7 Changed 15 years ago by Anduin Withers

Status: infoneeded_new → new

comment:8 Changed 15 years ago by laga

Milestone: 0.22 → 0.23

Postponing to 0.23.

comment:9 Changed 15 years ago by robertm

Resolution: → wontfix
Status: new → closed

This ticket is ancient, patch hasn't applied in a long, long time, we can open a task ticket if we want to do this kind of thing later.

comment:10 Changed 15 years ago by stuartm

Milestone: 0.23 → unknown
Note: See TracTickets for help on using tickets.