Opened 18 years ago

Closed 18 years ago

#1827 closed enhancement (fixed)

minor improvements to dvd seeking.

Reported by: skamithi Owned by: skamithi
Priority: minor Milestone: 0.20
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

in DVDRingBuffer::GetReadPosition?, sometimes dvdnav_get_position fails. this affects seeking. e.g, you are ffw and it just jumps to the beginning of the feature. trying a couple of things to see how to minimize the effects of this condition.

Attachments (5)

dvd_seeking_improvements_v1.patch​ (819 bytes) - added by skamithi 18 years ago.
if dvdnav_get_pos fails the first time, have some delay then try again. if its still wrong..oh well. seems to work most of the time. still testing.
dvd_seeking_improvements_addition.patch​ (551 bytes) - added by skamithi 18 years ago.
if getreadposition returns 0 tell decoderbase to use the current framesplayed.
dvd_seeking_improv.diff​ (4.1 KB) - added by skamithi 18 years ago.
dvd_seek_improv2.diff​ (1.9 KB) - added by skamithi 18 years ago.
noticed that when DVDRB::Seek is run and it fails, waiting til the next cell change makes it work again.
dvd_title_jumping.diff​ (1.9 KB) - added by skamithi 18 years ago.
allowing jumping to the next title when you reach the end of the title. previous restriction was that jumping is only allowed if chapters < 3

Download all attachments as: .zip

Change History (16)

Changed 18 years ago by skamithi

Attachment: dvd_seeking_improvements_v1.patch​ added

if dvdnav_get_pos fails the first time, have some delay then try again. if its still wrong..oh well. seems to work most of the time. still testing.

comment:1 Changed 18 years ago by skamithi

Resolution: → fixed
Status: new → closed

(In [10048]) Closes #1827. minor improvements in dvd ff/rew.

Changed 18 years ago by skamithi

Attachment: dvd_seeking_improvements_addition.patch​ added

if getreadposition returns 0 tell decoderbase to use the current framesplayed.

comment:2 Changed 18 years ago by skamithi

Resolution: fixed
Status: closed → reopened

some more improvements in dvd seeking.

  • stop been in rewind mode when at the beginning of the dvd
  • prevent dvd from jumping back to the beginning of the dvd when leaving rewind mode
  • prevent dorewind() or doforward() when leaving rewind mode while watching a dvd.

still testing the additional patch.

comment:3 Changed 18 years ago by skamithi

Status: reopened → new

comment:4 Changed 18 years ago by skamithi

Type: defect → enhancement

comment:5 Changed 18 years ago by skamithi

Status: new → assigned

Changed 18 years ago by skamithi

Attachment: dvd_seeking_improv.diff​ added

comment:6 Changed 18 years ago by skamithi

(In [10252]) Refs #1827. internal dvd player ff/rew improvements.

comment:7 Changed 18 years ago by skamithi

seekrwnd and seekffwd using internal dvd player doesn't work. working on a fix.

comment:8 Changed 18 years ago by skamithi

(In [10278]) Refs #1827. one change in [10252] broke skip ahead/behind for the internal dvd player. problem found by john poet.

Changed 18 years ago by skamithi

Attachment: dvd_seek_improv2.diff​ added

noticed that when DVDRB::Seek is run and it fails, waiting til the next cell change makes it work again.

Changed 18 years ago by skamithi

Attachment: dvd_title_jumping.diff​ added

allowing jumping to the next title when you reach the end of the title. previous restriction was that jumping is only allowed if chapters < 3

comment:9 Changed 18 years ago by skamithi

dvd_title jumping patch will allow you to jump to the next title even if the title is a dvd menu. i cannot find a function that allows me to look ahead and see if the next title in the chain is a dvd menu or not.

if i find it or get time to code it, i'll add it.

comment:10 Changed 18 years ago by skamithi

(In [10306]) Refs #1827. internal dvd player seeking changes. allow title jumping if current number of chapters in title > 2. also, added minor changes to the DVDRB::Seek function.

comment:11 Changed 18 years ago by skamithi

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.