Opened 18 years ago
Closed 18 years ago
Last modified 18 years ago
#2455 closed defect (fixed)
internal dvd player: subtitles don't get turned on automatically when set in the dvd menu.
Reported by: | skamithi | Owned by: | skamithi |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
if you say that you want to watch a dvd with subtitles through the dvd menus, then select the main title, the internal dvd player doesn't automatically enable the captions when the main title starts.
I have reproduced the problem. issue brought to my attention by pekka. reproduced it with a couple of dvds. It used to work in the past, i believe..but i can't remember.
Attachments (1)
Change History (5)
comment:1 Changed 18 years ago by
Changed 18 years ago by
Attachment: | ticket_2455.diff added |
---|
comment:2 Changed 18 years ago by
Status: | new → assigned |
---|
turned on dvdnav tracing. when (sprm[2] & 0x40) is true, then the dvd subtitles are on. tested this on about 6 dvds. will ask stuartm to confirm. moved 0x1F masking of the dvd stream number to dvdnav from dvdringbuffer, hopefully this will work for stuartm.
comment:3 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
1st problem. old bug i created.
in avformatdecoder.cpp around line 1500
should be
2nd issue: [10952] created part of the problem. says that if captionmode == kDisplayAVSubtitle, then attempt to turn on subtitles. but when starting a new title, captionmode is not set. so never turns on captions when the title begins.
3rd issue: [10870] on some dvds, sets the track number to 0 instead of a negative number when no subtitle is set. need to investigate the dvd spec further to find a way to better read this the dvd track number provided by dvdnav. so need to chat with stuartm to find a good resolution his problem and prevent what i saw.