Opened 18 years ago
Closed 17 years ago
#2473 closed patch (fixed)
Support for 'reversed polarity' LNBs
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Circularly polarizied LNBs when attached to satellite dishes that have two reflectors are reversed from their normal polarity (e.g., left-hand circular becomes right-hand circular). This patch adds a checkbox selector to the DiSEqC LNB configuration to support reversing the polarity of the LNB. Note that linear signals (i.e., horizontal and vertical) are not affected by this toggle.
This patch also adds two preset types for the existing circular LNB presets that are the same values but reversed.
Attachments (4)
Change History (15)
Changed 18 years ago by
Attachment: | lnb-reversed.patch added |
---|
comment:1 Changed 18 years ago by
Milestone: | unknown → 0.21 |
---|
Changed 18 years ago by
Attachment: | 2473-v1.patch added |
---|
Partially reviewed patch (I need someone with DiSEqC to sanity check this too).
comment:2 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [11371]) Fixes #2473. Adds support for polarity inversion in DiSEqC setups by applying modified patch from kenny at the b org.
This happens when using an even number of reflectors and a circularly polarized signal. In particular, this is a problem with those oddly shaped dishes that are used to recieve data from two different satelite constellations at once.
comment:3 Changed 18 years ago by
Priority: | minor → trivial |
---|---|
Resolution: | fixed |
Severity: | medium → low |
Status: | closed → reopened |
Type: | enhancement → defect |
In trunk/mythtv/libs/libmythtv/diseqc.cpp
line 1987 " lnb_pol_inv = :POLINV "
should be
line 1987 " lnb_pol_inv = :POLINV, "
missing comma.
comment:4 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:5 Changed 18 years ago by
Priority: | trivial → minor |
---|---|
Resolution: | fixed |
Severity: | low → medium |
Status: | closed → reopened |
I looks like the cmd_repeat and inv_pol database items are getting read/written in the wrong order in this patch.
mythconverg.diseqc_tree has lnb_pol_inv as the last item in the table but dieeqc.cpp sometimes has cmd_repeat as last. Check lines starting about 1943
comment:6 Changed 18 years ago by
Can you make a patch?
I don't have DiSEqC, or DVB for that matter, so my write->test->rewrite loop is quite long...
Changed 18 years ago by
Attachment: | 2473-fix-v1.patch added |
---|
Fixes single instance of reversed values in SELECT results.
comment:7 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:8 Changed 17 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
With this patch mythtv-setup doesn't allow dishpro LNB's to be saved. It also does not allow me to reverse the 'reversed polarity' LNB option.
comment:9 Changed 17 years ago by
To clarify you can now only select reversed polarity LNB's in mythtv-setup and nothing else. It won't save the setting if you disable reversed polarity.
Changed 17 years ago by
Attachment: | polinv.patch added |
---|
Fix the polarity inversion bool that was not saved in the DB
comment:10 Changed 17 years ago by
Type: | defect → patch |
---|
The polarity inverted flag was never saved to the DB due to type error.(svn head rev11464) I've just attached a patch that fixes this (polinv.patch) This is a nasty bug because the scanner is not working while the inversion is wrong!!
comment:11 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Patch to add in reversal of polarity for circularly polarized LNBs