Problem with Internal DVD Player Seek Amount

[fracmak]

This is kinda a wacky bug I've been experiencing with the dvd player. I have the rewind amount set for 5 seconds, but the dvd player doesn't always follow that setting. I've been trying to track down exactly what's causing it. I've attached a mythfrontend -v playback log snippet where I asked it to rewind 5 seconds, but it instead did a rewind of 20 seconds. I'd been playing the dvd for about 5 minutes before rewinding, it also went through a title change (tv show -> play all -> transition from one title/episode to the next).

[fracmak]

this is supposed to be assigned to "stanley kamithi" per mythtv-users

[skamithi]

i believe i've reproduced the issue. attaching patch shortly. pls test patch.

[skamithi]

the nvp/decoder framesplayed counter is often way off what the dvd frames played calculation produces.

sync the framesplayed counter to what the dvd framesplayed calculation produces before skipping forward or skipping behind. This should produce a consistent skip ffw and skip rew experience.

[fracmak]

I applied the patch and I'm still experiencing the same problem.

[skamithi]

i'll write a debug patch for you. i'm not sure then what the problem is.

[fracmak]

after playing with it a little more, seeking seem to be better, it isn't wildly off by 30+ seconds, but it still can be off by anywhere from 3 to 6 seconds. The best way I found to test it was to basically hit the fast forward (30 seconds) repeatedly, half the time it'll fast forward 30 seconds exactly, half the time it'll fast forward anywhere between 36 seconds and 27 seconds.

[skamithi]

since dvdnav_time_search in the dvdnav api is currently not implemented, i use a calculation to get the next seek position. it is not a precise calculation so it may be off, like you've seen.

since its not too far off, i'll just commit what is there and leave the implemenation of dvdnav_time_search function to someone else. whenever that's done, or if someone cares enough about this and comes up with a better way, then, of cause, the code will be changed.

[skamithi]

(In [11468]) Closes #2510. internal dvd player. makes jumps using seekrwnd, and seekfwd a little more predictable. its not precise but better then it was before.