Opened 17 years ago
Closed 17 years ago
#2804 closed patch (wontfix)
Cover thumbnails resize badly, it does not look good
Reported by: | Owned by: | xris | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythweb | Version: | head |
Severity: | medium | Keywords: | |
Cc: | anduin | Ticket locked: | no |
Description
On the videos page it takes the covers directly from the source, regardless of size, and resizes it in the browser. Having the browser resize images always looks terrible. This patch takes the source image, scale it down to the specified dimensions and cache it until something changes (modified time of the source image changes, specified dimensions change), at which point it will clear the cache and do it again.
Attachments (2)
Change History (6)
Changed 17 years ago by
Attachment: | mythweb.patch added |
---|
comment:1 Changed 17 years ago by
Cc: | anduin added |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
comment:2 Changed 17 years ago by
Here's a thought, what if I modified it to fallback to the current method if GD is not installed and display a small message about it?
That way it wouldn't be a dependency, just a recommendation.
Changed 17 years ago by
Attachment: | mythweb.2.patch added |
---|
comment:3 Changed 17 years ago by
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
Just remembered about this today.
I have updated it to the current SVN version and fixed it so if GD is not installed it just ignores it and carries on like it always has, displaying the unresized version. Have attached a new patch.
Recompiled PHP without GD support and it works fine.
comment:4 Changed 17 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
Before 0.21 is out mythweb will grab the cover artwork through the upnp/xml methods and so the backend will handle resizing the images.
As much as I'd like to apply this, it would better be solved by fixing mythvideo to store the covers in the db itself, possibly along with a thumbnail, and/or using a local cache in the mythweb directory rather than the db itself (and I can't have mythweb do any resizing because it would add yet another dependency, which I just can't do at the moment -- too many user complaints as it is).