Opened 17 years ago
Closed 17 years ago
#3550 closed patch (fixed)
MythMusic has duplicate entries under "All My Music" after applying a filter
Reported by: | anonymous | Owned by: | stuartm |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythmusic | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Say I'm listening to a track by a artist called ARTIST. If I hit 'f', select "Tracks by this artist" then navigate to "All My Music", I will see 2 entries of "Artists (A B C D E)". The first one will contain only "ARTIST" and the second one will contain all of the artists between [A-E] including "ARTIST". The reason for this is that when the filter is applied, the metadata for all tracks except those by "ARTIST" get setVisible set to false. In Playlist::fillSongsFromSonglist, the following code executes:
if(filter) {
all_available_music->buildTree(); all_available_music->sortTree();
}
AllMusic::buildTree() will only add entries for "ARTIST" because they will be the only tracks where isVisible() returns true. What this *doesn't* do is first clear the tree data previously stored in all_available_music, meaning that the duplicate appears.
The attach file fixes this as well as ticket #3536
Attachments (1)
Change History (4)
Changed 17 years ago by
Attachment: | mythmusic-debug.patch added |
---|
comment:1 Changed 17 years ago by
Milestone: | unknown → 0.21 |
---|---|
Owner: | changed from Isaac Richards to stuartm |
comment:2 Changed 17 years ago by
Type: | defect → patch |
---|
comment:3 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fix Duplicate Entry in All My Music