Opened 17 years ago
Closed 16 years ago
#3623 closed defect (fixed)
'make uninstall' does not clean out all empty installation directories
Reported by: | Nick Morrott <knowledgejunkie [at] gmail [dot] com> | Owned by: | Nigel |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | make uninstall |
Cc: | Ticket locked: | no |
Description
After dispensing advice on -users about using 'make uninstall' to remove a locally compiled and installed MythTV installation, I thought I'd better test the functionality and check whether it does clean everything up that did not exist before, bar user-generated files.
The results are as follows (after running 'make uninstall' for myththemes, mythplugins and mythtv in that order i.e. reverse of installation order):
# ls -l /usr/local/bin/myth* ls: /usr/local/bin/myth*: No such file or directory # ls -l /usr/local/lib/libmyth* ls: /usr/local/lib/libmyth*: No such file or directory # ls -l /usr/local/lib/mythtv/ total 0 # ls -l /usr/local/include/mythtv/ total 0 # ls -lR /usr/local/share/mythtv/ /usr/local/share/mythtv/: total 8 drwxr-xr-x 2 root root 4096 Jun 16 08:10 mytharchive drwxr-xr-x 2 root root 4096 Jun 16 08:10 mythvideo /usr/local/share/mythtv/mytharchive: total 0 /usr/local/share/mythtv/mythvideo: total 0
From this process it therefore seems that the following directories are not being removed:
/usr/local/share/mythtv/mytharchive /usr/local/share/mythtv/mythvideo /usr/local/share/mythtv /usr/local/include/mythtv /usr/local/lib/mythtv
Is this something that needs to be addressed? I can attempt a suitable patch if it is.
Nick
Change History (7)
comment:1 Changed 16 years ago by
Milestone: | unknown → 0.21 |
---|---|
Owner: | changed from Isaac Richards to stuartm |
Status: | new → assigned |
comment:2 Changed 16 years ago by
Owner: | stuartm deleted |
---|---|
Status: | assigned → new |
comment:3 Changed 16 years ago by
Owner: | set to Nigel |
---|---|
Status: | new → assigned |
comment:4 Changed 16 years ago by
Status: | assigned → accepted |
---|
This isn't a huge problem - running make ununstall a second time should work around the bug, but it should be fixable. There are two things happening here. 1) some directories may not be empty when uninstall is trying to remove them. e.g.:
(I will try to fix that extra libmyth dir soon - it is related to [15545])
2) sequencing. qmake is installing and uninstalling in the same order, which means that the Makefile in the subdir that creates and removes the top-level installed dir is called too early. I will try to add extra rmdir commands to the uninstall targets in libs.pro