Opened 17 years ago
Closed 16 years ago
#4043 closed defect (fixed)
GET_CURRENT_RECORDING doesn't get updated when recgroup changes
| Reported by: | anonymous | Owned by: | Janne Grunau |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythtv | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
When the recgroup changes (someone hits 'r'), GET_CURRENT_RECORDING doesn't reflect the change. Patch attached.
Attachments (2)
Change History (9)
Changed 17 years ago by
| Attachment: | patch.diff added |
|---|
comment:1 Changed 17 years ago by
The first patch presents a bug when a user is prompted that a recording is to start and the user opts to watch while recording. The recording stays in the LiveTV group for some reason and stops recording when the user exits LiveTV. The second patch eliminates this by not calling CheckForRecGroupChange?() in TVRec::GetRecording?().
comment:2 Changed 16 years ago by
(In [15291]) Fix typo and simplify UpdateRecGroup?(). Refs #4043 Based on patches by Shane < gmone42 {at} gmail [p] com >
comment:3 Changed 16 years ago by
| Milestone: | unknown → 0.21 |
|---|---|
| Status: | new → infoneeded_new |
Is it fixed with revision [15294]?
comment:4 Changed 16 years ago by
Not fixed. This is what happens:
- The user hits the record button while watching TV.
- The frontend changes the recgroup in the db.
- The frontend queries the backend for recording status.
- The backend replies back based on old info since it doesn't reread the db for any changes the frontend may have made.
The patch in 15294 fixes UpdateRecGroup?() but that's only called by TV::PromptRecGroupPassword?(). Since UpdateRecGroup?() is only called by one method, maybe that method should be updated to use ProgramInfo::ApplyRecordStateChange?() instead so UpdateRecGroup?() can be eliminated.
- Mark.
comment:5 Changed 16 years ago by
| Status: | infoneeded_new → new |
|---|
comment:6 Changed 16 years ago by
| Owner: | changed from Isaac Richards to Janne Grunau |
|---|---|
| Status: | new → assigned |
comment:7 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [15806]) If we switch from LiveTV to pseudoLiveTVRecording or vice versa, update the recgroup in the curRecording object. This is done rather than reretrieving from the DB so that we don't have to keep track of other changed values such as curRecording->recstatus.
The patch.