Opened 16 years ago
Closed 16 years ago
#4327 closed enhancement (fixed)
[PATCH] Re-write of the eit code for uk DVB
Reported by: | john { at } pullan {dot} org | Owned by: | Stuart Auchterlonie |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | eit | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
First off, this code incorporates the #3980 fix. Secondly it also attempts to gain more subtitle knowledge from the description. (Takes the first six words up to a period or question mark). Thirdly it fixes some less than tidy code where "..." was being stuck together. Fourthly it adds another series detection mode. Fifthly it fixes a bug in the code where "CSI:" was not being correctly parsed, i.e "CSI:Crime Scene Investigation" was being split into program.title=CSI program.subtitle=Crime Scene Investigation.
Attachments (18)
Change History (39)
Changed 16 years ago by
Attachment: | eitfixup.patch added |
---|
comment:1 Changed 16 years ago by
Milestone: | unknown → 0.21 |
---|---|
Owner: | changed from Isaac Richards to Stuart Auchterlonie |
Status: | new → assigned |
Changed 16 years ago by
Attachment: | eitfixup1.patch added |
---|
comment:2 Changed 16 years ago by
comment:3 Changed 16 years ago by
This didn't get linked to the ticket when I originally submitted it.
(In [15178]). Closes #4327. Refs #3980. UK EIT fixup by john {at} pullan {dot} org
Does a bunch of cleanups to the EIT fixups for the UK, which make it more correct and fix a few niggly issues that people have noticed.
Now handles CSI properly as well as some cases where the ... joining code was incorrectly propagating the whole title/subtitle/desc into the title.
Only one small change from the original patch, which makes sure the airdate being used as a title/description delimiter still works.
comment:4 Changed 16 years ago by
comment:5 Changed 16 years ago by
comment:6 Changed 16 years ago by
Added another update to help prevent the munging of times across subtitles and descriptions.
Changed 16 years ago by
Attachment: | eitfixup3.patch added |
---|
comment:8 Changed 16 years ago by
Status: | assigned → started |
---|
Changed 16 years ago by
Attachment: | eitfixup7.patch added |
---|
comment:9 Changed 16 years ago by
This patch to the base code strips the trailing white space from the eit entries, also prevents time events being split across subtitle/description and also adds another entry to the "New episode" (eitfixup7.patch)
comment:10 Changed 16 years ago by
eitfixup8.patch
Added code to remove "Series" subtitles
Removed slightly broken code for the CBBC/CBeebies
comment:11 Changed 16 years ago by
Fixed snafu with episode numbers (not being removed)
Remove "BBC4 on BBC TWO" type things
Improved (hopefully), the removal of "New"
comment:12 Changed 16 years ago by
(In [15334]) Refs #4327. Another UK EIT fixup update from JohnP. This is based upon his eitfixup8 patch with a few bits from eitfixup9 to fix a problem where the titles were being completely blatted. I've also added a check to make sure that the partnumber is not greater than the parttotal. This stops things like 24/7 being caught as a partnumber/parttotal.
comment:13 Changed 16 years ago by
Took out the code which was confusing : and -
Also fixed a problem where "1983:" was activating too soon.
comment:14 Changed 16 years ago by
comment:16 Changed 16 years ago by
Stuff include in this patch:
- Implementation of "New." which seems to help with "New. Doc Martin ..."
- Use of isMovie (not really accurate but it does help)
- Removal of all sub title descriptions
- Much greater use of SetUKSubtitle
Feel free to pick and choose, although I would recommend getting the "New." bit.
Changed 16 years ago by
Attachment: | eitfixup13.patch added |
---|
Changed 16 years ago by
Attachment: | eitfixup14.patch added |
---|
comment:17 Changed 16 years ago by
- Added better subtitle detection
- Added "emergency" repair for "-" titles. (if no subtitle, but has "-" use that)
Changed 16 years ago by
Attachment: | eitfixup15.patch added |
---|
comment:18 Changed 16 years ago by
Fixed a few things:
- Fixed the "BBC 4 on BBC Two".
- Combined a lot of the other removals.
- Fixed issue of a subtitle ending up just containing dots.
- Fixed issue of a Radio 5 Live not having the correct subtitle, due to it having a time in it.
- Fixed the description being promoted to the subtitle.
Changed 16 years ago by
Attachment: | eitfixup17.patch added |
---|
comment:20 Changed 16 years ago by
Component: | mythtv → eit |
---|
comment:21 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | started → closed |
Up date of patch