Opened 16 years ago
Closed 15 years ago
#4501 closed enhancement (fixed)
Allow browsing across tuners
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | stuartm | Ticket locked: | no |
Description
I've put together a set of patches that allow users to view channels from all tuners in the LiveTV browse mode. It has the following features:
- Enabled via a toggle in TV Settings -> Playback OSD (disabled by default)
- Adds 2 extra attributes to the infoMap for use in the OSD
1) tuner = "Current Tuner", "Tuner #", or empty if no tuner is available for that channel 2) notuner = "No Tuners Available", or empty if a tuner is available for that channel
- Allows textarea objects in osd.xml (which maps to the OSDTypeText class) to support a fcnfont option. This allows you to do things like make the program title appear in red if there are no tuners available to watch the program.
I'm attaching 3 patches:
Patch 1: Implements the fcnfont support for OSD textarea objects.
Patch 2: Implements the actual tuner browsing featuers.
Patch 3: Demonstrates how to support the fcnfont in the blueosd theme. I am not necessarily proposing that this patch be applied as is...just providing an example of how the new UI features can be implemented in a theme.
Attachments (6)
Change History (12)
Changed 16 years ago by
Attachment: | osd_fcnfont.patch added |
---|
Changed 16 years ago by
Attachment: | browse_tuners.patch added |
---|
allows browsing across multiple tuners
Changed 16 years ago by
Attachment: | browse_tuners_theme_example.patch added |
---|
example of how to implement in a theme
comment:1 Changed 16 years ago by
Cc: | stuartm added |
---|
comment:2 Changed 16 years ago by
Hi,
I'm also looking into this issue and came across your patches. I tried the browse_tuners.patch on its own, (with a few small mods needed to compile without the font patch), and it worked well. :)
There's always concern about additional network traffic and DB load generated by the channel checking and input groups checking stuff so I was experimenting trying to minimize that.
Came up with a patch with these changes for the browse_tuners.patch:
- Use TV::IsTunable?(), this eliminates the need for adding TV::GetProgramTunerStatus?() and TV::FindAvailableTuner?().
- Add TV::GetChanIDAnyTuner(const QString &chan) to avoid GetChanNum?() DB query.
- Reuse the ProgramInfo? from GetNextProgramAnyTuner?() to TV::BrowseDispInfo?(), saves re-getting the program info from the DB.
- Dropped TV::GetProgramTunerStatus?().
- Constify new functions.
comment:3 Changed 15 years ago by
I'd love to use this patch, as the people I'm building a mythbox for don't want to switch to the channel guide just to switch 1 channel.
There appears to be a problem with the ":BROWSETS" variable in some query:
2008-09-25 22:49:14.023 Query contains bind value ":BROWSETS" twice: SELECT DISTINCT program.chanid, program.starttime, program.endtime, program.title, program.subtitle, program.description, program.category, channel.channum, channel.callsign, channel.name, program.previouslyshown, channel.commmethod, channel.outputfilters, program.seriesid, program.programid, program.airdate, program.stars, program.originalairdate, program.category_type, oldrecstatus.recordid, oldrecstatus.rectype, oldrecstatus.recstatus, oldrecstatus.findid FROM program LEFT JOIN channel ON program.chanid = channel.chanid LEFT JOIN oldrecorded AS oldrecstatus ON program.title = oldrecstatus.title AND channel.callsign = oldrecstatus.station AND program.starttime = oldrecstatus.starttime WHERE program.chanid = :CHANID AND program.starttime <= :BROWSETS AND program.endtime > :BROWSETS GROUP BY program.starttime, channel.channum, channel.callsign, program.title ORDER BY program.starttime, atsc_major_chan,atsc_minor_chan,channum,callsign LIMIT 1000
comment:4 Changed 15 years ago by
I forgot to mention I'm using the latest trunk, not the fixes release. The patch does not cleanly apply to it, but with some tweaking I got it right.
Changed 15 years ago by
Attachment: | mythtv_browseall_03-trunk.patch added |
---|
Browse across all tuners patch for trunk (QT4)
comment:5 Changed 15 years ago by
Owner: | changed from Isaac Richards to danielk |
---|---|
Status: | new → assigned |
Changed 15 years ago by
Attachment: | 4501-v1.patch added |
---|
Updated patch to trunk, not tested or reviewed
fcnfont support for OSD textarea objects