Opened 16 years ago
Closed 14 years ago
#4807 closed patch (fixed)
Save & use last tuned channel for entering LiveTV
| Reported by: | Owned by: | Stuart Auchterlonie | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.24 |
| Component: | MythTV - DVB | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | stuartm | Ticket locked: | no |
Description
This patch saves the last (successfully) tuned channel so it can be used by LiveTV when first entering it.
The last tuned channel is stored as chanid in settings for the frontend and only saves after NuppleVideoPlayer::OpenFile?() successfully opens and reads the file - to ensure it's a good channel.
To test yet:
- Saving last tuned channel when streaming is on.
Attachments (5)
Change History (18)
Changed 16 years ago by
| Attachment: | save_last_chan.diff added |
|---|
Changed 16 years ago by
| Attachment: | save_last_chan2.diff added |
|---|
Make sure the channel IsTunable?() before using it.
comment:1 Changed 16 years ago by
Tested successfully with streaming turned on. I've finalized the patch with an addition of IsTunable?() of the saved chanid. If the saved chanid is IsTunable(), or points to an unavailable capture card or is 0/undefined, the logic reverts back to the original behavior.
- Mark.
comment:2 Changed 15 years ago by
| Owner: | changed from Isaac Richards to stuartm |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | nuppel_save.diff added |
|---|
Additional patch required for PVR-type tuners.
comment:3 Changed 15 years ago by
I've added an additional patch necessary for PVR-type tuners since they operate differently than DVB-types.
- Mark.
comment:4 Changed 15 years ago by
| Owner: | stuartm deleted |
|---|---|
| Status: | assigned → new |
comment:5 Changed 15 years ago by
See, also #6708 for a different implementation of a patch to only save startchan if tuning succeeds.
comment:6 Changed 15 years ago by
| Cc: | stuartm added |
|---|---|
| Component: | mythtv → MythTV - General |
comment:7 Changed 14 years ago by
| Component: | MythTV - General → MythTV - DVB |
|---|
Not exactly the right component, but maybe it'll get some visibility outside of General and we can get something like this implemented.
comment:8 Changed 14 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
[TICKET CLEANUP] Although I think this is a good idea, closing as it has gone years without any attention. I *do* think something like this should get applied, so if you still feel strongly about it, please feel free to open a new ticket with a patch against trunk.
comment:9 follow-up: 10 Changed 14 years ago by
Mark,
The closing of this has caused one or two of us to peer at these tickets. Can you comment on the benefits of your patch versus the far simpler patch on #6708.
Does this change the behaviour when using livetv?
Stuart
comment:10 Changed 14 years ago by
Replying to stuarta:
Does this change the behaviour when using livetv?
That should have been
Does this patch change the behaviour only when using livetv?
Stuart
comment:11 Changed 14 years ago by
| Milestone: | unknown → 0.24 |
|---|---|
| Resolution: | wontfix |
| Status: | closed → new |
| Version: | head → Trunk Head |
Mark's comment:
Yes, only livetv is effected. I've been using this patch for the past two years with no ill effect to recording.
The difference with this patch vs. 6708 is that this takes a few more things into consideration, like if the channel is tunable (enough free capture cards, etc) and the default channel (chanid) is stored and used per/frontend and can survive a backend restart. The chanid is only stored after the channel has been successfully tuned.
comment:12 Changed 14 years ago by
| Owner: | set to Stuart Auchterlonie |
|---|---|
| Status: | new → assigned |
comment:13 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The patch.