dvd problems with the matrix dvds.

[skamithi]

recently purchased the matrix set of dvds. Found some problems. this ticket to document problems resolved using this dvd set.

1st problem is a crash because audioOutput is called in the video playing thread and it may be null when audio is disabled in the decoding thread. moving audioOutput call out of the video thread.

[skamithi]

(In [17178]) Refs #5275. internal dvd player. move audioOutput call out of the video playing thread. prevents a recently seen crash when changing from dvd title to the dvd root menu.

[skamithi]

(In [17199]) Refs #5275. internal dvd player: undo [17178]. it was causing problems on other dvd. objective is to prevent audio from been paused in the dvd menu without calling audioOutput->Pause(false) in the video thread. this seems to do the trick.

[skamithi]

(In [17261]) Refs #5275. apply audioOutput->drain() only to still frames. fixes dvd menu lockup in the matrix dvd and also in the sahara(2005) dvd.

[skamithi]

(In [17265]) Refs #5275. replace dvdPriv::IsInMenu? with a more accurate definition. matrix bonus disc uses title zero for the main feature.

[skamithi]

(In [17266]) Refs #5275. internal dvd player. remove some unnecessary code when navigating the dvd menu.

[skamithi]

(In [17267]) Refs #5275. internal dvd player: fix the cell change detection code and total title length detection code. fixes problem where the wrong title length is reported and can cause ff/rew issues.

[skamithi]

(In [17270]) Refs #5275. internal dvd player. allow buttons to work in the "super burly brawl" section of matrix revolutions bonus disc. ffw/rw in this section will cause a crash in this section.looking into it. let me know if this change causes major differences navigating some dvd menus. i know some dvds have "hidden" buttons in some dvd menu sections. this patch may prevent you from jumping through those sections.

[skamithi]

(In [17271]) Refs #5275. forgot one small addition to [17270]

[skamithi]

(In [17285]) Refs #5275. internal dvd player. make dvd menu button reappear after a video flushing event (NVP::clearafterseek).

[skamithi]

(In [17305]) Refs #5275. internal dvd player fixes: commit [17178], [17199], [17261], [17265], [17266], [17267], [17270], [17271], [17285] from trunk to fixes.