Opened 16 years ago

Closed 16 years ago

#5449 closed defect (fixed)

prevent overrun of _pid_status in MpegRecorder

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

_pid_status has 8191 values but there are 8192 possible PIDs. It is possible to overrun it with PID 8192 (the null PID).

The attached patch adds one more for _stream_id, _pid_status and _continuity_count.

Your mission if you choose to accept it is to refactor DVBRecorder and MpegRecorder? so that the code for the above arrays is shared between them instead of copied.

Attachments (1)

libs_libmythtv_mpegrecorder.h-prevent-overrun-of-_pid_status.patch​ (912 bytes) - added by Erik Hovland <erik@…> 16 years ago.
Adds one more to the arrays _stream_id, _pid_status and _continuity_count

Download all attachments as: .zip

Change History (3)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythtv_mpegrecorder.h-prevent-overrun-of-_pid_status.patch​ added

Adds one more to the arrays _stream_id, _pid_status and _continuity_count

comment:1 Changed 16 years ago by danielk

(In [17515]) Refs #5449. Fix buffer allocation, was one byte short.

comment:2 Changed 16 years ago by danielk

Resolution: → fixed
Status: new → closed

fixed by [17515].

Note: See TracTickets for help on using tickets.