Opened 16 years ago

Closed 12 years ago

#5468 closed Developer Task (Won't Fix)

[TASK] Remove abort() calls in code

Reported by: danielk Owned by: danielk
Priority: trivial Milestone: unknown
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by danielk)

There are 12 abort) calls in mythtv, these errors should be handled more gracefully: 

libs/libavcodec/mpegvideo.c:    abort();
libs/libavcodec/shorten.c:            abort();
libs/libmythdvdnav/decoder.c:    abort();
libs/libmythdvdnav/decoder.c:   abort();
libs/libmythdvdnav/decoder.c:      abort();
libs/libmythdvdnav/nav_read.c:    abort();
libs/libmythdvdnav/nav_read.c:  if (!getbits_init(&state, buffer)) abort(); /* Passed NULL pointers */
libs/libmythdvdnav/nav_read.c:  if (!getbits_init(&state, buffer)) abort(); /* Passed NULL pointers */
libs/libmythdvdnav/vm.c:    abort();
libs/libmythdvdnav/vm.c:    abort();
libs/libmythdvdnav/vm.c:    abort();
libs/libmythdvdnav/vm.c:    abort();

Change History (7)

comment:1 Changed 16 years ago by danielk

Description: modified (diff)

comment:2 Changed 15 years ago by Dibblah

Status: new → assigned

comment:3 Changed 15 years ago by stuartm

Component: mythtv → MythTV - General
Type: defect → task

comment:4 Changed 14 years ago by danielk

ugh, there are now 22 abort calls in the code. We're regressing...

comment:5 Changed 13 years ago by beirdo

Summary: Remove abort() calls in code → [TASK] Remove abort() calls in code
Type: task → Developer Task

comment:6 Changed 13 years ago by beirdo

Please add assert() to this list, as these also cause very inelegant crashing. Great for debugging, not so great for a release build.

comment:7 Changed 12 years ago by danielk

Resolution: → Won't Fix
Status: assigned → closed

I'm just not going to find the time to deal with the problems in the DVD libs & the ones in FFmpeg are unlikely to cause MythTV exits.

Note: See TracTickets for help on using tickets.