Opened 16 years ago
Closed 16 years ago
#5570 closed defect (fixed)
Remove most Qt3 stuff from libmythtv
Reported by: | danielk | Owned by: | danielk |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
The attached patch removes most Qt3 things from the libmythtv library. The remaining stuff either uses Qt networking stuff or is in libmyth headers.
This also patches some bits of the libmyth & programs directories as needed for de-Qt3-ifying libmythtv.
This has been mildly tested by me so far, any additional testing is appreciated, especially systematic testing.
Attachments (4)
Change History (14)
Changed 16 years ago by
Attachment: | 5570-v1.patch added |
---|
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
comment:3 follow-up: 4 Changed 16 years ago by
I've split the remaining Qt3->Qt4 conversions for libmythtv into three patches:
- MHI -- I can't test this, and apparently no one can at the moment.
- Quartz -- I can't test this, but it's probably good to go.
- Channel -- This needs more work, the existing locking was insufficient, but I need to audit all the channel classes to make sure we don't add more locking than we need since some of the Channel classes already have some locking.
comment:4 Changed 16 years ago by
Replying to danielk:
I've split the remaining Qt3->Qt4 conversions for libmythtv into three patches:
- MHI -- I can't test this, and apparently no one can at the moment.
I can test this as it's integral to the MHEG stuff that i'm having a bash at.
comment:5 Changed 16 years ago by
comment:6 Changed 16 years ago by
comment:7 Changed 16 years ago by
comment:8 Changed 16 years ago by
(In [17971]) Refs #5570. Daniel's patch was perfect, bar a typo and an interesting warning:
videoout_quartz.cpp: In member function 'void QuartzData::ClearViews()': videoout_quartz.cpp:108: warning: possible problem detected in invocation of delete operator: videoout_quartz.cpp:108: warning: invalid use of undefined type 'struct VideoOutputQuartzView' videoout_quartz.cpp:68: warning: forward declaration of 'struct VideoOutputQuartzView' videoout_quartz.cpp:108: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined.
which warranted a slight re-org of the internal class def'ns. Seems to work OK.
comment:10 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [17929]) Refs #5570. Commits ProgramInfo? portion of Qt3 removal patch.
This is one of the less rote conversions so I separated out so I could test it independently, and if needed revert it independently.