Opened 16 years ago
Closed 15 years ago
#5606 closed patch (fixed)
MHEG Update
Reported by: | Owned by: | Stuart Auchterlonie | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | stuartm | Ticket locked: | no |
Description
This patch comprises various bug fixes and a few updates related to MHEG on Freesat.
Bugs fixed include:
- Fixed problem with text with colour changes (Text.cpp)
- Removed erroneous Qt prefixes added in the conversion to Qt4 (freemheg.h). Also change QImage constructors to use correct Format argument (mhi.cpp) for Qt4.
- Fixed problems with gaps between display items due to the OSD seeming to align items onto even bit boundaries (mhi.cpp)
- Calculate correct size for video when resizing HD. The BBC have just started transmitting MHEG on BBC HD and without this fix the picture may be resized to a quarter of the screen. Also avoid resizing if the size hasn't changed (mhi.cpp, mhi.h)
- Rewrite of DrawPolygon?. This is used to draw direction arrows on Freesat and didn't work properly (mhi.cpp)
Added support for Interactible and Slider classes. Sliders are used on Freesat for scrollbars to provide feedback when reading multi-page news items. (various files in libmythfreemheg).
The patch is against SVN head but it's mostly been tested against the fixes branch.
Attachments (5)
Change History (17)
Changed 16 years ago by
Attachment: | mhegupdate.patch added |
---|
comment:1 Changed 16 years ago by
Cc: | stuartm added |
---|---|
Milestone: | unknown → 0.22 |
comment:2 Changed 16 years ago by
Owner: | changed from Isaac Richards to Stuart Auchterlonie |
---|---|
Status: | new → assigned |
comment:3 Changed 16 years ago by
I think we'll also accept a patch against -fixes for this issue since the change breaks BBC HD for anyone who has MHEG enabled.
comment:4 Changed 16 years ago by
comment:5 Changed 16 years ago by
I'm adding a patch for the fixes branch and also an additional patch for HEAD for another problem I found. When copying a bitmap to produce a tiled image creating an image with the same pixel depth would produce messages about "Invalid index". The patch for the fixes branch includes everything in the previous patch as well as this change.
Changed 16 years ago by
Attachment: | fixes-mhegupdate.patch added |
---|
Changed 16 years ago by
Attachment: | bitmapfix.patch added |
---|
comment:7 Changed 16 years ago by
Thanks, this patch fixes bbc hd for me when applied to fixes, so I would also liketo see it applied in svn. On a related freesat mheg note, is there any fix for the sports multiscreen? When I select it mythtv changes to the stream channel, but I can't select any other multiscreen from the menu, nor can I get off that channel except by the last channel button.
comment:8 Changed 15 years ago by
(In [18762]) Refs #5606. Turns off qt3 compat for libmythtv by default.
There are two things that are now disabled by default because they have not yet been ported, dbox2 support and mheg support. These can be enabled by using --enable-dbox2 and --enable-mheg respectively when running ./configure.
Enabling either one will pull in the qt3 compat library. I'll be attaching a patch to #5606 shortly which does a partial port to Qt4 for MHEG, but someone with access to MHEG streams will need to complete the port.
I highly suggest doing a make distclean, but it should not be required in most cases.
Changed 15 years ago by
Attachment: | 5606-qt4-port-v1.patch added |
---|
Beginnings of a Qt4 port of MHEG code
comment:9 Changed 15 years ago by
I hadn't realised Daniel had actually done quite a bit of the port already when I did this this morning but it looks very similar. I've done a quick test of it and it seems to work fine. Eventually I'd like to remove Qt from within libfreemheg itself since that would make it easier to reuse the code in other projects.
David.
comment:10 Changed 15 years ago by
David, in my patch I used a Qt4 bitBlt (drawImage with a pixmap) for MHIBitmap::Draw(), (in mhi.cpp) but you used pixel by pixel assignment. Does the bitBlt not work, or you just missed it?
I also don't like two C arrays that replace the QPointArray, I'd rather see an stl::vector<MHEGPoint> which keeps track of it's bounds internally; but that's a minor issue.
comment:11 Changed 15 years ago by
comment:12 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I've been looking at the QT4 port of this, so i'll take it.