Opened 16 years ago
Closed 15 years ago
#5673 closed defect (fixed)
The ctor for Eventing in libmythupnp is missing some member initialization
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | trivial | Milestone: | unknown |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The ctor for Eventing is missing initialization for m_nHoldCount and m_pInitializeSubscriber.
Attachments (1)
Change History (2)
Changed 16 years ago by
Attachment: | libs_libmythupnp-uninit.patch added |
---|
comment:1 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [19444]) Fixes #5673. Fixes ctor for Eventing.
Note: I also added a warning on m_nHoldCount exceeding 127 (the guarranteed maximum in the range of a short) My impression is that the author meant to use a int16_t not a short (or he would have probably just used a signed char which has the same guarrantees as short.) If so nKey in SubscriberInfo? is probably a more immediate problem, since it can have a range anywhere from 0..255 to 0..4294967295 on typical machines and the actual valid range is defined by a UPnP spec.
adds member initialization to Eventing