Opened 16 years ago

Closed 10 years ago

#5742 closed Patch - Feature (Won't Fix)

MythWeb Music last play filter

Reported by: otto at kolsi dot fi Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached patch adds Last Play filter to MythWeb Music Random Mix Maker. Together with Rating filter, this can be used to e.g. find "good songs not played recently".

I first used "<" and ">" symbols in UI but then changed these to "earlier than" and "later than" texts which feel more natural.

Patch has couple of new translations and English language file modifications are included in the patch. Not sure if this is needed or not.

Attachments (2)

mythweb-music-lastplay.patch​ (5.3 KB) - added by otto at kolsi dot fi 16 years ago.
mythweb-music-lastplay-v2.patch​ (16.3 KB) - added by otto at kolsi dot fi 15 years ago.

Download all attachments as: .zip

Change History (19)

Changed 16 years ago by otto at kolsi dot fi

Attachment: mythweb-music-lastplay.patch​ added

comment:1 Changed 16 years ago by otto at kolsi dot fi

If I remember correctly, there was a bug in music scan/import which did set the lastplay column in music_songs table to the timestamp of import (when it should be NULL).

If anyone is interested, following SQL statement can be used to fix this small issue in DB: 

update music_songs set lastplay = NULL where numplays = 0;

comment:2 Changed 15 years ago by Rob Smith

Status: new → infoneeded_new

Patch doesn't apply cleanly to current trunk, care to update?

comment:3 Changed 15 years ago by otto at kolsi dot fi

Yes, I can update the patch but that'll take some time since I'll probably have to move my "production" from fixes to trunk. So if this ticket could stay open a bit longer than normally...

Changed 15 years ago by otto at kolsi dot fi

Attachment: mythweb-music-lastplay-v2.patch​ added

comment:4 Changed 15 years ago by otto at kolsi dot fi

Attached new patch which applies to mythweb trunk.

comment:5 Changed 15 years ago by Rob Smith

Status: infoneeded_new → new

comment:6 Changed 15 years ago by Rob Smith

Owner: changed from xris to Rob Smith
Status: new → accepted

comment:7 Changed 15 years ago by Rob Smith

Component: mythweb → Plugin - MythWeb
Owner: Rob Smith deleted
Status: accepted → new

comment:8 Changed 15 years ago by Rob Smith

Milestone: unknown → 0.23

comment:9 Changed 14 years ago by robertm

Pushing to .24 since we're in freeze.

comment:10 Changed 14 years ago by robertm

Milestone: 0.23 → 0.24

comment:11 Changed 14 years ago by robertm

Milestone: 0.24 → unknown
Owner: set to paulh
Status: new → assigned

comment:12 Changed 14 years ago by paulh

Owner: changed from paulh to Rob Smith

comment:13 Changed 14 years ago by Rob Smith

Milestone: unknown → 0.25

comment:14 Changed 14 years ago by stuartm

Milestone: 0.25

Milestone 0.25 deleted

comment:15 Changed 13 years ago by Rob Smith

Milestone: 0.25 → unknown
Version: head → Trunk Head

We're planning a full rewrite of the main mythweb template. This is going to be postponed until after that is complete.

comment:16 Changed 13 years ago by stuartm

Type: patch → Patch - Feature

Kormoc, same question as #8970. is that planned re-write now postponed? Can this patch not be committed now in time for 0.25?

comment:17 Changed 10 years ago by Rob Smith

Resolution: → Won't Fix
Status: assigned → closed

Given Mythweb is EOL, I'm closing new features. This should be done via the backend webserver now.

Note: See TracTickets for help on using tickets.