Opened 18 years ago
Closed 18 years ago
#579 closed defect (fixed)
EIT does not insert program descriptions
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.19 |
| Component: | dvb | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
mythtv no longer inserts descriptions for from EIT data. i've checked with dvbsnoop that i do have program descriptions, i have also added some extra logging to the guide fixup function to verify that there is a description.
but, when insert_program() in eithelper.cpp is about to insert the data to mysql the description field is empty.
i don't know why this happens, any ideas?
Attachments (6)
Change History (19)
comment:1 Changed 18 years ago by
comment:2 Changed 18 years ago by
comment:4 Changed 18 years ago by
Can you try with the latest SVN? I just cleaned this code up a bit.
Also did you set the Guide Languages to languages you get OTA? If you run the backend with "-v siparser" do you get any messages like:
Added preferred language eng with priority 3
?
comment:5 Changed 18 years ago by
i tried with latest svn and now both title and description is empty :-) so now it's worse than before. mythweb shows just some colored boxes with noting in them.
and no i did not set any guide languages, didn't know i had to and besides shouldn't this just work even if you dont set anything? think about new users or those upgrading, it woud be kind of confusing getting empty descriptions and titles by default.
comment:6 Changed 18 years ago by
| Milestone: | → 0.19 |
|---|---|
| Priority: | major → minor |
Discussion moved to dev mailing list.
Changed 18 years ago by
| Attachment: | mythbackend.log.bz2 added |
|---|
compressed since over 40000 lines, setup with 3 dvb cards
comment:7 Changed 18 years ago by
Changed 18 years ago by
| Attachment: | siparser.patch added |
|---|
comment:8 Changed 18 years ago by
Could you try the attached patch please. It was resetting the best matches in the wrong place.
comment:9 Changed 18 years ago by
the siparser patch does the trick.
I get now events just like with rev [7718].
comment:10 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [7770]) Fixes #579, by applying patch from John Pullan.
It looks like it was just a two line fix in the end that did it, the descriptor caches were being cleared at the start of the parse of each descriptor.
But I'm glad I cleaned up all that language selection stuff in the meantime. After [7758], it now initializes the preferred listings/subtitle/audio languages from the UI language, and it also handles the alternate language strings such as "deu"tch for "ger"man and "isl"enska for "ice"landic.
comment:11 Changed 18 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I think this needs one more adjustment. In searching for the largest priority we have to keep the largest one stored until the end of the descriptor list.
I try to attach my patch (first-time trac user). I have verified it in Finland with two languages in EIT, but with SE only, I think. And with r7770.
Mikko
mikko.suonio@…
Changed 18 years ago by
| Attachment: | mythtv_fix_eit_extended_events_lang_selection.diff added |
|---|
different fix for language selection
comment:12 Changed 18 years ago by
I didn't see other patch before I was done.
Basicly the same solution, but with cleanup of the rather useless bestLanguage?? strings. If (priority <= bestpriority) you can use the current language string. Otherwise I don't see any reason to use the string value of the best matching language.
comment:13 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
i forgot, some programs do get a descriptions, but most don't.