Opened 16 years ago

Closed 16 years ago

#5826 closed patch (fixed)

Cleanup before exit for time zone mismatch

Reported by: sphery <mtdean@…> Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch adds a call to cleanup() before returning *_EXIT_INVALID_TIMEZONE in mythfrontend and mythbackend.

Once applied, the shutdown sequence will result in the 2 additional log messages:

QWaitCondition: cv destroy failure: QWaitCondition: mutex destroy failure:

which makes it seem like it's adding a new problem, but those same messages appear for other some other return *EXIT* conditions. For example, they appear when cleanup is called before "return FRONTEND_EXIT_DB_OUTOFDATE;".

Note, also, that the "return FRONTEND_EXIT_INVALID_CMDLINE;" when trying to run a plugin directly through command-line arguments (in the "if (pluginname.size())" block) is not preceded by a call to cleanup(). It is late enough in initialization that the call to cleanup() is probably necessary. The attached patch does not add the call to cleanup() for that case.

Attachments (1)

mythtv-5826-cleanup_after_time_zone_mismatch.patch (1.0 KB) - added by sphery <mtdean@…> 16 years ago.

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by sphery <mtdean@…>

comment:1 Changed 16 years ago by Anduin Withers

Owner: changed from Isaac Richards to Anduin Withers
Status: newaccepted

comment:2 Changed 16 years ago by Anduin Withers

(In [18718]) References #5826

Always call cleanup() when needed.

comment:3 Changed 16 years ago by Anduin Withers

Resolution: fixed
Status: acceptedclosed

(In [18719]) Closes #5826

Removes most manual calls to cleanup().

Note: See TracTickets for help on using tickets.