Opened 15 years ago
Closed 14 years ago
#6318 closed enhancement (fixed)
recGroup direct access for PBB
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.23 |
Component: | MythTV - User Interface Library | Version: | head |
Severity: | medium | Keywords: | mythui recording groups |
Cc: | Ticket locked: | no |
Description
The recGroup-cycle.patch adds the ability to cycle through the user defined recording groups directly using the PAGERIGHT and PAGELEFT keys while in the PBB. This is much faster than bringing up the menu, and selecting which recording group to view.
The recGroup-ui.patch lets the theme optionally display the list of recording groups, with the current group highlighted.
The recGroup-Terra.patch, recGroup-default-wide.patch and recGroup-metallurgy_svn_10_01_09.patch(es) are not really polished. I am including them to demonstrate what a theme needs to do, to take advantage of the recGroup-ui feature. I also figured it would make it easier to review these patches.
I have almost 1300 recordings. Using these patches makes it much quicker to find the show I want to watch, by significantly reducing the amount of data I have to page through.
Attachments (24)
Change History (41)
Changed 15 years ago by
Attachment: | recGroup-cycle.patch added |
---|
Changed 15 years ago by
Attachment: | recGroup-ui.patch added |
---|
Changed 15 years ago by
Attachment: | recGroup-default-wide.patch added |
---|
Changed 15 years ago by
Attachment: | recGroup-Terra.patch added |
---|
Changed 15 years ago by
Attachment: | recGroup-metallurgy_svn_10_01_09.patch added |
---|
Changed 15 years ago by
Attachment: | recGroup-cycle-1a.patch added |
---|
comment:1 Changed 15 years ago by
Replaced the recGroup-cycle patch, with one that removes some useless code.
Changed 15 years ago by
Attachment: | recGroup-cycle-v1.1.patch added |
---|
new version with recGroupType getting set properly
comment:2 Changed 15 years ago by
Attached a new version of recGroup-cycle. Just adds one line, to get recGroupType set properly.
comment:3 Changed 15 years ago by
Milestone: | unknown → 0.23 |
---|---|
Type: | patch → enhancement |
Version: | unknown → head |
Changed 15 years ago by
Attachment: | recGroup-default-wide.2.patch added |
---|
Updated patch for the default-wide theme
Changed 15 years ago by
Attachment: | recGroup-metallurgy_svn_10_01_09.2.patch added |
---|
Update patch for the metallurgy theme
comment:5 Changed 15 years ago by
I realize I'm just one user, but I wanted to throw my two cents behind this patch (recGroup-cycle-v1.1.patch). I have the same problem as jppoet (lots of recordings in different groups) and this patch makes my myth experience significantly better.
Thanks jppoet! -Doug
comment:6 Changed 15 years ago by
(In [21261]) Allow the PAGELEFT and PAGERIGHT keybindings to cycle through Recording Groups in the Watch Recordings screen.
References #6318. I'll let Stuart look the UI/theme patch attached to the ticket since he took this ticket a few months ago.
This patch is by John P Poet, but I added the locking around the Recording Group cache so that we don't try to access the cache while it is being rebuilt by PlaybackBox::FillList?().
Changed 15 years ago by
Attachment: | recGroup-Terra.3.patch added |
---|
Update Terra patch for trunk 21437
comment:8 Changed 15 years ago by
Status: | new → accepted |
---|
Changed 15 years ago by
Attachment: | recGroup-metallurgy_svn_10_01_09-v2.patch added |
---|
Minor optimizations
comment:10 Changed 15 years ago by
Oops. recGroup-ui-v2.patch had one-line of residue from a different patch. Attaching recGroup-ui-v2a.patch, which has that residue removed.
Changed 14 years ago by
Attachment: | recGroup-default-v1.patch added |
---|
Changed 14 years ago by
Attachment: | recGroup-default-wide-v3.patch added |
---|
Changed 14 years ago by
Attachment: | recGroup-Terra-v5.patch added |
---|
Changed 14 years ago by
Attachment: | recGroup-Graphite-v1.patch added |
---|
Changed 14 years ago by
Attachment: | recGroup-metallurgy-v2.patch added |
---|
comment:12 Changed 14 years ago by
Changed 14 years ago by
Attachment: | recGroup-ui-v3.patch added |
---|
Don't display recGroup buttonlist if there is only one recording group.
comment:13 Changed 14 years ago by
New version of patch (v3) which will not draw the recGroup buttonlist if there is only one item in it.
comment:14 Changed 14 years ago by
patch does not apply anymore with trunk 23063.
patching file programs/mythfrontend/playbackbox.cpp Hunk #1 succeeded at 474 (offset 38 lines). Hunk #2 succeeded at 492 (offset 39 lines). Hunk #3 FAILED at 942. Hunk #4 succeeded at 1273 (offset 68 lines). Hunk #5 FAILED at 1737. 2 out of 5 hunks FAILED -- saving rejects to file programs/mythfrontend/playbackbox.cpp.rej patching file programs/mythfrontend/playbackbox.h Hunk #1 FAILED at 314. Hunk #2 FAILED at 328. 2 out of 2 hunks FAILED -- saving rejects to file programs/mythfrontend/playbackbox.h.rej
comment:16 Changed 14 years ago by
Owner: | changed from stuartm to danielk |
---|---|
Status: | accepted → assigned |
comment:17 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Remove some useless code