Opened 15 years ago
Closed 15 years ago
Last modified 15 years ago
#6591 closed patch (fixed)
Check MSqlQuery::exec() return value
Reported by: | Owned by: | Janne Grunau | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | MythTV - General | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
The attached patches modify usage of MSqlQuery::exec() to check the return value. The most important reason for doing this is because QSqlQuery::lastError() may indicate an error even when the query executed successfully (see http://www.qtsoftware.com/developer/task-tracker/index_html?id=248078&method=entry ) in Qt 4.5.
Attachments (8)
Change History (13)
Changed 15 years ago by
Attachment: | mythtv-6591-check_return_value_of_MSqlQuery_exec-important.patch added |
---|
Changed 15 years ago by
Attachment: | mythtv-6591-check_return_value_of_MSqlQuery_exec-libmythtv.patch added |
---|
Fixes all unchecked exec() calls in libmythtv. Mostly just adds new log messages or rearranges success checks. Fixes a couple DBError messages with copy/paste errors (wrong function name)
Changed 15 years ago by
Attachment: | mythtv-6591-check_return_value_of_MSqlQuery_exec-libmythtv.2.patch added |
---|
mythtv-6591-check_return_value_of_MSqlQuery_exec-libmythtv.patch had one mistake, use this version, instead
Changed 15 years ago by
Attachment: | mythtv-6591-check_return_value_of_MSqlQuery_exec-programs.patch added |
---|
Fixes all occurrences in programs. These are the last occurrences in mythtv. (Haven't checked mythplugins.)
comment:1 Changed 15 years ago by
Milestone: | unknown → 0.22 |
---|---|
Owner: | changed from Isaac Richards to Janne Grunau |
Status: | new → accepted |
comment:2 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Changed 15 years ago by
Attachment: | mythtv-6591-check_return_value_of_MSqlQuery_exec-libmythtv.3.patch added |
---|
Updated patch--removes unnecessary isActive() calls and programdata changes (which were fixed by Daniel in a previous commit).
Changed 15 years ago by
Attachment: | mythtv-6591-check_return_value_of_MSqlQuery_exec-programs.2.patch added |
---|
Updated patch--removes unnecessary isActive() calls.
comment:3 Changed 15 years ago by
Changed 15 years ago by
Attachment: | mythplugins-6591-check_return_value_of_MSqlQuery_exec.patch added |
---|
Fixes all occurrences in mythplugins. Adds logging, removes unnecessary isActive() and size() calls.
Changed 15 years ago by
Attachment: | mythplugins-6591-check_return_value_of_MSqlQuery_exec.2.patch added |
---|
Updated mythplugins patch--was missing a couple of #includes for mythdb.h
comment:4 Changed 15 years ago by
comment:5 Changed 15 years ago by
(In [20936]) Check MSqlQuery::exec() return value in MythPlugins?. Patch from Micheal T Dean. Refs #6591.
Most important fixes in mythtv--cases that rely on QSqlQuery::lastError() and ignore MSqlQuery::exec()