Opened 15 years ago
Closed 14 years ago
Last modified 14 years ago
#6681 closed patch (Unverified)
Switching between Video and TV over PiP Video always starts at latest Bookmark
Reported by: | Owned by: | Shane Shrybman | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - Video Playback | Version: | Unspecified |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
Steps to Reproduce:
- Start a Video from your recordings
- Press "V" for PiP.
- switch to TV
- Go back to Video
Result: Video starts from last bookmark, or if there is none, from the beginning. Also Pausing is not possible with PiP functionality, but that maybe a feature.
Attachments (1)
Change History (8)
comment:1 Changed 15 years ago by
Component: | MythTV - General → MythTV - Video Playback |
---|---|
Milestone: | 0.23 → 0.22 |
Owner: | changed from Isaac Richards to Shane Shrybman |
Status: | new → accepted |
Version: | unknown → head |
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
Status: | accepted → started |
---|---|
Type: | defect → patch |
The attached patch further mitigates the race condition on fftime when a bookmark is set and swapping PiPs?/PBPs.
It has been working well here but is a bit risky due to being in the main NVP::StartPlaying?() path. So, it needs lengthy testing before committing.
Changed 15 years ago by
Attachment: | 6681_move_bookmark_seek_for_PxPSwap.diff added |
---|
comment:4 Changed 14 years ago by
Milestone: | 0.22 → 0.24 |
---|
Bumping open 0.22 milestone tickets to 0.24
comment:5 Changed 14 years ago by
Status: | started → infoneeded |
---|
Not sure if this is still relevant after the MythUI OSD conversion. Can we get a test against current trunk? If still present, old patch is undoubtedly no longer applicable.
comment:6 Changed 14 years ago by
Resolution: | → Unverified |
---|---|
Status: | infoneeded → closed |
Shane if you happen to read this and think the patch should still apply then please re-open with an updated patch.
comment:7 Changed 14 years ago by
Milestone: | 0.24 → unknown |
---|---|
Version: | head → Unspecified |
(In [20777]) Refs #6681. Fix restoring of file position after PiP/PBP Swap.
Fix a race setting the fftime variable by moving SetPlaying?(true) after fftime is initially set in NVP::StartPlaying?().
There is still a known problem with racing with the fastforward to the initial bookmark. Mitigate that in a separate patch.