MythWeather only allows one location/source per screen type.

[Marc Alban <marcalban@…>]

On the trunk MythWeather? is only allowing one location/source per screen type.

If you add two or more screens of the same type, MythWeather? works correctly until you exit MythWeather? and reenter. When you reenter all screens that have the same type contain data for the screen with the greatest draw order.

This is caused because of the way the 'ScreenListInfo?' object is created and accessed.

Using a copy constructor when loading the screen data instead of pointer assignment fixes the problem.

[Marc Alban <marcalban@…>]

Patch to fix how MythWeather? handles multiple screens of the same type.

[paulh]

Marc, while your patch does fix the issue I haven't applied it yet because there's a small problem of it leaking memory. The copies of the ScreenListInfo?'s you are creating are never freed. Any chance you could fix that?

[Marc Alban <marcalban@…>]

Yeah I did notice that after I submitted the patch, but got side tracked hunting down some other memory leaks in MythWeather?. I'll update the patch and create a new ticket for some other leaks I found.

[Marc Alban <marcalban@…>]

Updated patch without the memory leak.

[Marc Alban <marcalban@…>]

I created ticket #6856 for the broader memory leak issues with MythWeather? and attached a patch.

[paulh]

(In [21443]) Fix a problem in MythWeather? were it would only allow one location/source per screen type to be set. Fixes #6782.

Also fixes several memory leaks. Fixes #6856.

Patch by Marc Alban.