Opened 15 years ago
Closed 14 years ago
Last modified 14 years ago
#6824 closed task (fixed)
Speed up mythcommflag
| Reported by: | danielk | Owned by: | beirdo |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.24 |
| Component: | MythTV - General | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
See if avformatdecoder settings can speed up mythcommflag without losing too much in the way of accuracy.
Attachments (5)
Change History (17)
Changed 15 years ago by
| Attachment: | 6824-v1.patch added |
|---|
comment:1 Changed 14 years ago by
| Status: | new → assigned |
|---|
Changed 14 years ago by
| Attachment: | 6824-v2.patch added |
|---|
comment:2 Changed 14 years ago by
| Version: | head → 0.23rc2 |
|---|
I'm not guaranteeing that this patch is correct, but I've done my best to update it to be off trunk ([25462] in fact). Daniel, or someone else, could you verify that I shoehorned in the rejects correctly? In particular, the one with the sws_scale is done differently now, and I'm not sure I got it quite right.
comment:3 Changed 14 years ago by
| Version: | 0.23rc2 → Unspecified |
|---|
comment:4 Changed 14 years ago by
| Version: | Unspecified → Trunk Head |
|---|
comment:6 Changed 14 years ago by
OK, there's at least one tweak to be made to the patch... in avformatdecoder.cpp, a gContext needs to be changed to gCoreContext to get it to compile.
Changed 14 years ago by
| Attachment: | 6824-v3.patch added |
|---|
comment:7 Changed 14 years ago by
The last patch has the stated tweak so it will compile. Please note these patches are made with git format-patch, and you may need to remove the mail headers from them first if your patch program can't handle it.
comment:8 Changed 14 years ago by
| Owner: | changed from danielk to beirdo |
|---|
Changed 14 years ago by
| Attachment: | 6824-v4.patch added |
|---|
comment:9 Changed 14 years ago by
Updated the patch to allow for the CommFlagFast? setting to be 0 in the database, and enabled the one last enhancement.
comment:10 Changed 14 years ago by
Newest version includes setting the CommFlagFast? db setting from the General (Jobs) setup page in the frontend (where the commflag type is set). It now defaults to disabling if there's no setting found in the db, and is treated as a boolean.
This setting will be removed once this patch has been sufficiently tested, at which point, a commandline option will be added to force a disable.
Changed 14 years ago by
| Attachment: | 6824-v5.patch added |
|---|
comment:11 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [25657]) Added commercial detection speedups. This works primarily by using a scaled down version of the recording to detect commercials (1/4 width, 1/4 height), and by doing blank frame detection using less of the frame.
Preliminary testing has shown that the commercial breaks found are as accurate if not more accurate with this enabled as with it disabled, with occasional missed commercials. This seems no worse than without it, and commercial detection is not a simple thing anyways.
There is a new setting in the TV -> General (Jobs) screen to allow the user to enable these speedups, and the default is to have the speedups disabled.
Closes #6824
comment:12 Changed 14 years ago by
| Milestone: | unknown → 0.24 |
|---|
Proof of concept patch