Opened 15 years ago
Closed 14 years ago
Last modified 14 years ago
#7167 closed defect (fixed)
Check the return value of function calls inside of mythfrontend
Reported by: | Owned by: | stuartm | |
---|---|---|---|
Priority: | trivial | Milestone: | 0.24 |
Component: | MythTV - General | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
Quite a few UI and configuration calls return a value. Maybe they should be checked?
Attachments (4)
Change History (10)
Changed 15 years ago by
Attachment: | programs_mythfrontend-check-return added |
---|
Changed 15 years ago by
Attachment: | programs_mythjobqueue-check-return added |
---|
Same kind of return value checking in mythjobqueue
Changed 15 years ago by
Attachment: | programs_mythlcdserver-check-return added |
---|
Check the return value of dup2
Changed 15 years ago by
Attachment: | programs_mythtv-setup-check-return added |
---|
Check some return values in mythtv-setup
comment:1 Changed 15 years ago by
I'd sooner remove the return value of BuildFocusList?() than add all those checks. The only time we return false would is when we're missing focusable widgets and that's perfectly valid if the screen works without them. If the screen doesn't work without them then it's a code error, the author has failed to check that the required widgets exist in the theme. So altogether it's redundant for BuildFocusList?() to return any value at all.
comment:2 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|---|
Owner: | changed from Isaac Richards to stuartm |
Status: | new → accepted |
Erik, BuildFocusList? no longer returns true/false, so the frontend patch needs updating.
comment:3 Changed 14 years ago by
(In [23967]) Always check the return of ConnectToMasterServer?() in programs/. Patch from Erik Hovland. Refs #7167
comment:4 Changed 14 years ago by
Status: | accepted → infoneeded |
---|
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | infoneeded → closed |
No update. (Please feel free to reopen if you get around to this).
comment:6 Changed 14 years ago by
No sweat. I do have a patch. But I will have to see what it does currently. Thanks for keeping up w/ the ticket.
Check the return value of calls in mythfrontend