Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#7589 closed patch (fixed)
LCD is not cleared after finishing watching a recording
| Reported by: | Owned by: | Isaac Richards | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - General | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
After exiting a recording the LCD screen is not reset and will remain displaying the status of the recording.
Patch attached
Attachments (2)
Change History (7)
Changed 14 years ago by
| Attachment: | tv_play.cpp.diff added |
|---|
comment:1 Changed 14 years ago by
| Resolution: | → worksforme |
|---|---|
| Status: | new → closed |
| Version: | 0.22 → head |
Can't reproduce this in trunk. The TV destructor already calls LCD::switchToTime() so don't see what your patch does that we don't already do.
comment:2 Changed 14 years ago by
I have checked the configuration of my MythTV setup and I think that the difference is that I have disabled the time display in the LCD. Under the settings -> appearance -> LCD device display configuration screen I have disabled the "display time" and "display menus" options. Switching to the non-existent time display will not cause the current display to be removed.
Changed 14 years ago by
Better handling of show time and show recording status
comment:3 follow-up: 5 Changed 14 years ago by
| Resolution: | worksforme |
|---|---|
| Status: | closed → new |
I guess no one envisioned someone would want to turn the time display off because all of Myth uses that as a default if there is nothing else to show. While your patch will fix the problem after exiting playback there are other places where it is also broken.
Can you please test the attached patch. It should always clear the lcd if switchToTime() is called and show time is off and it should also handle having show recording status on and show time off properly.
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [23256]) Fixes a problem where the lcd wasn't being cleared as it should if the show time setting was turned off. Should also work better for all combinations of show time and show recording status better. Fixes #7589.
Not tested every possible combination of LCD settings so if you spot any problems let me know and I will fix it.
comment:5 Changed 14 years ago by
Replying to paulh:
Can you please test the attached patch. It should always clear the lcd if switchToTime() is called and show time is off and it should also handle having show recording status on and show time off properly.
I have been running the patch for a couple of days now and it seems to work the same as the original patch that I included.
Patch for tv_play.cpp