Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#7680 closed patch (fixed)
Use image/jpeg enclosures as thumbnails in MythNews
Reported by: | otto at kolsi dot fi | Owned by: | Isaac Richards |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | Plugin - MythNews | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Attached patch adds support for jpeg images in <enclosure> tags so that these are treated like thumbnails.
Modification to mythnews.cpp fixes issue where previous thumbnail image was shown for current news article when current article does not have thumbnail. I noticed this while working with the enclosure improvement. Even if that part would not be applied, this fix probably should be.
Following feed can be used to test both enclosures and the case where (most of the time) not every article/item has a thumbnail/enclosure: http://yle.fi/uutiset/rss/news.rss
Without this patch, those jpeg image enclosures are treated as downloadable media. They are downloaded (I think, haven't verified) when you select that article but then nothing is shown. What's more problematic is that this download behaviour blocks the feature where you can open the article to MythBrowser?. So without this patch, you cannot open the articles (with enclosures) in above feed.
Attachments (1)
Change History (3)
Changed 14 years ago by
Attachment: | mnews-enclosure-image.patch added |
---|
comment:1 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [22990]) Use image/jpeg enclosures as thumbnails in MythNews? instead of trying to play them. Patch from Otto. Fixes #7680.