Opened 14 years ago
Closed 10 years ago
Last modified 10 years ago
#7730 closed Patch - Bug Fix (fixed)
Mythweb - allow direct downloading of .mkv, .avi, .mp4, .xvid, .okv files
| Reported by: | Owned by: | Karl Egly | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.26.2 |
| Component: | Plugin - MythWeb | Version: | 0.22-fixes |
| Severity: | medium | Keywords: | mythweb download mkv ogg avi mp4 xvid |
| Cc: | Ticket locked: | no |
Description
Using 0.22-fixes, ver 22594
Trying to "Direct Download" any filetype in Recordings other than mpeg, mpg, or nuv results in "Unknown filetype" error.
This patch allows for downloads of multiple filetypes, useful when manually importing files into the database.
If the format of the patch is incorrect, I apologize in advance - this is my first time doing this.
Attachments (3)
Change History (13)
Changed 14 years ago by
| Attachment: | stream_raw.pl.diff added |
|---|
comment:1 Changed 14 years ago by
| Priority: | minor → trivial |
|---|---|
| Status: | new → infoneeded_new |
| Type: | defect → enhancement |
Barry, looks like you diffed this in reverse-- this is a patch for removing your enhancement. ;)
Try changing the order of the files in your diff -u command, or simply patch an svn copy and use "svn diff" to create the patch.
Changed 14 years ago by
| Attachment: | stream_raw.pl.2.diff added |
|---|
now ADDING the patch to the file, not removing. whoops.
comment:2 Changed 14 years ago by
| Status: | infoneeded_new → new |
|---|
comment:3 Changed 14 years ago by
| Status: | new → infoneeded_new |
|---|
Barry, did you test this? It is full of mismatched braces. I'm no PHP expert, but presumably you still need to close the brace you open.
comment:4 Changed 14 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | infoneeded_new → closed |
No update to the patch to address the mismatched braces. Please feel free to re-open when you have a tested, syntactically correct version.
Changed 10 years ago by
| Attachment: | stream_raw.pl added |
|---|
Add mp4, avi, mov, wmv, 3gp, ogv, webm to the types that can be directly downloaded
comment:5 Changed 10 years ago by
I have re-opened the ticket and added an updated patch adding additional filetypes to allow them to be direct downloaded. I use a "userjob" to transcode recordings into MP4 format, and have tested the patch with that format.
comment:6 Changed 10 years ago by
| Resolution: | wontfix |
|---|---|
| Status: | closed → new |
Attached patch for commit.
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:10 Changed 10 years ago by
| Milestone: | unknown → 0.26.2 |
|---|---|
| Owner: | changed from Rob Smith to Karl Egly |
| Type: | enhancement → Patch - Bug Fix |
modified stream_raw.pl to allow for Direct Download of multiple filetypes