Opened 14 years ago

Closed 14 years ago

#7742 closed defect (fixed)

MythMusic does not correctly report the required number of info lines

Reported by: micahgalizia@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: Plugin - MythMusic Version: 0.22-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Currently, in databasebox.cpp, an error is reported if the info container in the music_select window (from music-ui.xml) has fewer than three info textarea tags. However, mythmusic really expects six (as per DatabaseBox::entered), so the error should be reported if there are fewer than six info textarea tags.

A side effect of this error not reporting correctly is a crash when the TreeCheckItems? are entered. However, theme creators may overlook this if they do not traverse the tree to a leaf node.

Attachments (1)

infolines.patch​ (690 bytes) - added by micahgalizia@… 14 years ago.
Display error screen if there are fewer than six info textareas.

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by micahgalizia@…

Attachment: infolines.patch​ added

Display error screen if there are fewer than six info textareas.

comment:1 Changed 14 years ago by micahgalizia@…

The attached patch was generated from the main trunk (not 0.22-fixes, as the ticket says).

comment:2 Changed 14 years ago by stuartm

Resolution: → fixed
Status: new → closed

(In [23267]) We weren't checking for enough lines in MythMusic's databasebox. Patch from Micah Galizia. Fixes #7742

Note: See TracTickets for help on using tickets.