Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#7759 closed patch (fixed)
[PATCH] Add support for repeat_pict plus related AV-sync improvements
| Reported by: | Owned by: | markk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.23 |
| Component: | MythTV - Video Playback | Version: | unknown |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I've created a patch that implements the correct video delays when frames with the repeat_pict flag are processed. This dramatically improves playback for HD 720p and 1080i broadcast material. Also included are some AV-sync improvements which improve next trigger management. I'm including a complete patch and also in parts to allow ease of integration and discussion.
- Part 1
This implements the repeat_pict delay logic in NVP and also increases the allowed delay by CalcDelay? in vsync.cpp
- Part 2
The next trigger was being allowed to fall behind too far when trying to speed up video playback faster than possible. This caused severe playback issues when repeated frames were encountered or a frame dropped.
- Part 3
This prevents the trigger from being advanced when a frame is dropped. If the frame is dropped but the next trigger is advanced you lose the benefit of dropping the frame.
This set of patches fully addresses all the problems I've seen in the past and also resolves some extreme cases reported in the following discussion:
Attachments (7)
Change History (12)
Changed 14 years ago by
| Attachment: | t7759_repeat_pict_v1.diff added |
|---|
Changed 14 years ago by
| Attachment: | t7759_repeat_pict_v1_part1.diff added |
|---|
Part 1 only includes repeat_pict changes
Changed 14 years ago by
| Attachment: | t7759_repeat_pict_v1_part2.diff added |
|---|
Part 2 only includes negative trigger handling
Changed 14 years ago by
| Attachment: | t7759_repeat_pict_v1_part3.diff added |
|---|
Part 3 only includes drop frame enhancement
comment:1 Changed 14 years ago by
For anyone interested in testing this please use the t7759_repeat_pict_v2.diff patch. The separate "part" patches are just to break it apart for integration and analysis purposes.
comment:2 Changed 14 years ago by
| Owner: | changed from Janne Grunau to markk |
|---|---|
| Status: | new → accepted |
comment:3 Changed 14 years ago by
| Milestone: | unknown → 0.23 |
|---|
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
(In [23321]) Add support for the repeat_pict count and improve the handling of certain A/V sync cases with patch from Taylor Ralph.
I'm guessing that there may still be extreme cases where the repeat_pict value is higher than the sync code can handle but otherwise this appears to be working well.
Closes #7759.
Full patch including repeat_pict and AV-sync improvements