mpegts demuxer sets codec_tag incorrectly

[thfisher@…]

Changeset 20971 introduced a minor bug in the setting of codec->codec_type.

In the function

new_pes_av_stream()

, the line

    st->codec->codec_tag = pes->stream_type;

is setting the codec_tag to the ISO stream id instead of the appropriate tag. (eg. 0x1b for H264 instead of 'H264').

While this doesn't appear to break anything in trunk now, it does break the patches for anyone using CoreAVC, and may break something in the future.

Commenting out the line or applying the attached patch resolve the immediate problem with the CoreAVC patch however there may be a better way to handle this.

[thfisher@…]

Patch to improve setting of codec_type.

[robertm]

The code is from upstream, and we're making efforts to be more like them, not less so. Changes like this, especially when there's no existing bug in actual Myth code, are discouraged. If you want something like this to find its way into myth, I daresay you'll need to get it applied upstream (submit your patch to ffmpeg-devel).