Add quoting to the location passed to the weather parsers

[knight@…]

Hi,

This quotes the location passed to the weather parsers so that its content is not interpreted by the command line parser.

The same kind of quoting was already done during the search of the city/town/region.

Thank you,

Nick

[dstancl@…]

Another solution: add escapeshellcmd to method WeatherScreen::runScript:

$command  = escapeshellcmd("$script $args");

[Nicolas Riendeau <knight@…>]

Replying to dstancl@…:

Another solution: add escapeshellcmd to method WeatherScreen::runScript:

$command  = escapeshellcmd("$script $args");

The description of what this does sounds to me like it could cause problems with some parsers.

Interesting command though... (-;

[Rob Smith]

(In [24932]) Fixes #7817, this should do escaping properly for all the shell tasks in the weather module

[Miguel Yarza <miguel.yarza@…>]

There is an error in the GetData function runScript argument escaping, last two arguments are being escaped together.

I got it working escaping arguments separately:

$output_array = $this->runScript($script, '-u '. escapeshellarg($units) 
.' -d '. escapeshellarg(getcwd() .'/'. data) .' '. escapeshellarg($location));

I attach a diff against [24932] with the fix.

[Miguel Yarza <miguel.yarza@…>]

Fix for GetData? function runScript argument escaping

[Rob Smith]

(In [26223]) Fixes #7817, this properly escapes the location argument with the mythweather module in mythweb