Opened 14 years ago
Closed 11 years ago
#8217 closed Patch - Bug Fix (Fixed)
programs from xmltv source around DST change are off by 2h
| Reported by: | Owned by: | sphery | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | MythTV - Mythfilldatabase | Version: | Master Head |
| Severity: | medium | Keywords: | DST UTC XMLTV QT |
| Cc: | Ticket locked: | no |
Description
fromXMLTVDate is using QtDateTime::addSecs to calculate UTC time in Auto mode. Now if addSecs hits a DST change it will honor that an mess up our calculation.
To stop addSecs from doing this the TimeSpec? has to be set to Qt::UTC.
See attached path for a quick fix.
PS: Perhaps its time do drop MythUTCToLocal and use correct TimeSpecs? and QtDateTime::toLocalTime?
Attachments (1)
Change History (5)
Changed 14 years ago by
| Attachment: | addSecsDST.patch added |
|---|
comment:1 Changed 14 years ago by
| Owner: | changed from stuartm to sphery |
|---|---|
| Status: | new → accepted |
comment:2 follow-up: 3 Changed 12 years ago by
| Type: | patch → Patch - Bug Fix |
|---|---|
| Version: | head → Master Head |
comment:3 Changed 12 years ago by
Replying to stuartm:
Where does this fit with the switch to using GMT internally?
uhm.... wow!
Took a quick look at utc changes... should still be the same.
Note: I stopped using xmltv over a year ago. 2nd Note: You may only experience the bug for programs starting/stopping during the hour of DST Change as that's where QtDateTime::addSecs is doing it's magic.
comment:4 Changed 11 years ago by
| Milestone: | unknown → 0.27 |
|---|---|
| Resolution: | → Fixed |
| Status: | accepted → closed |
Should be fixed in [ff5ab27842c522f9e054876a8eb69a51b8c86a2e] in master by removing the code in question.
Where does this fit with the switch to using GMT internally?