Channel icon download selection doesn't work in several themes

[Kenni Lund <kenni@…>]

It's impossible to download channel icons in mythtv-setup when using some themes, as the selection is invisible. You can move up and down, but in the end you don't know which icon you select.

Themes affected by the problem:

• Metallurgy
  
• Mythbuntu
  
• Mythcenter
  
• Mythcenter-wide (Widescreen)
  

Themes not affected by the problem:

• Arclight
  
• Childish
  
• Graphite
  

Tested on 0.23-fixes r24358 in Mythbuntu 10.04.

$ mythfrontend.real --version
Please attach all output as a file in bug reports.
MythTV Version   : 24358
MythTV Branch    : branches/release-0-23-fixes
Network Protocol : 56
Library API      : 0.23.20100429-1
QT Version       : 4.6.2
Options compiled in:
 linux debug using_oss using_alsa using_pulse using_jack using_pulseoutput using_backend using_dvb using_firewire using_frontend using_glx_proc_addr_arb using_hdhomerun using_hdpvr using_iptv using_ivtv using_joystick_menu using_libudev using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtdbus using_qtwebkit using_v4l using_x11 using_xrandr using_xv using_xvmc using_xvmc_vld using_xvmcw using_bindings_perl using_bindings_python using_opengl using_vdpau using_ffmpeg_threads using_libavc_5_3 using_live using_mheg

[robertm]

The affected themes don't have a themed iconimport window, so they're falling back to default.

[robertm]

Kenni, you can test the above patch if you like, otherwise I will test when I get home tonight.

[robertm]

Fix channel picker buttonlist

[Kenni Lund <kenni@…>]

That was quick :) But no, it doesn't solve it. The selection is now visible when the icons are not in focus (for example when you move the selection to one of the buttons), but the selection is still not visible when moving the selection around on the icons. The buttons also have much more contrast in the green color with the patch applied.

[Kenni Lund <kenni@…>]

"The buttons also have" -> "The icons also have"

[robertm]

(In [24417]) Fix #8417. Add a selectedinactive state type to the default icon picker screen, making the selected item in the grid obvious. I'm going to implement a similar fix for the basebuttonlist2 in MythCenter? as one of the other icon screens isn't obvious either.

[robertm]

(In [24418]) Refs #8417. Backport icon picker buttonlist fix to .23-fixes.