Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#8432 closed defect (fixed)
61 strings in channelscanmiscsettings.h are not translatable
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.24 |
Component: | MythTV - Channel Scanner | Version: | Master Head |
Severity: | medium | Keywords: | translation i18n |
Cc: | Ticket locked: | no |
Description
None of the 61 strings in mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h are translatable, eg. the strings are not added to the *.ts files when running QT lupdate.
They do use QObject::tr("xxxxx"), but something else is wrong.
Some of the strings exists in the *.ts files, but this is purely a coincidence, as some of the strings also exists in other source files.
Attachments (3)
Change History (9)
comment:1 Changed 14 years ago by
Changed 14 years ago by
Attachment: | channelscan_tr.diff added |
---|
comment:2 Changed 14 years ago by
OK, I had to do a tad more work than expected once I added the missing entry in the translate.pro as there were a few tr() calls which weren't prefixed by QObject.
Kenni, can you test this to see if it does what you want (I can't test this since we're not supposed to use channel scans here (North America) with the kind of tuner I have)?
Thank you and have a nice day!
Nick
Changed 14 years ago by
Attachment: | channelscan_tr_v2.diff added |
---|
comment:3 Changed 14 years ago by
Thanks Nicolas,
I've attached an updated version of your patch, fixing some similar issues. I'll see if I'll be able to test it later today, otherwise it'll be in a few days.
Changed 14 years ago by
Attachment: | channelscan_tr_v3.diff added |
---|
comment:4 Changed 14 years ago by
I've tested v3 of the patch and it seems to work fine. It makes it possible to translate a total of ~50 new strings in the *.ts files. I did a test translation of these strings, and all of those which I was able to find in mythtv-setup/mythfrontend, were now translatable.
Feel free to commit if you don't spot any errors :)
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|
Hi,
It would appears that there is a missing entry in the translate.pro...
<< SOURCES += ../libs/libmythtv/channelscan/*.h
There's already one for the .cpp in that directory but not the .h...
Give me a few minutes and I'll attach a patch...
Have a nice day!
Nick