Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#8466 closed defect (fixed)
version 6.x of Date::Manip perl module breaks some compatibility with 5.x
| Reported by: | Owned by: | beirdo | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.24 |
| Component: | Plugin - MythWeather | Version: | 0.23-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Mythbuntu (and Ubuntu in general) 10.04 picked up and distributed the 6.x version of Date::Manip. A user has since noticed that MythWeather? was only updating once a day. I've traced this back to the author of the version 6 of the Date::Manip perl module deciding to break compatibility with previous versions: "today", "tomorrow", and "yesterday" now behave differently (http://search.cpan.org/~sbeck/Date-Manip-6.11/lib/Date/Manip/Changes5to6.pod#DATE_PARSING_AND_OPERATIONS).
The attached patch applies to both 0.23 and trunk, and replaces "today" with "now". Using "now" is backwards compatible with 5.x, so backporting should not affect existing installs.
There is one occurrence of tomorrow (used as "8am tomorrow"), but it seems to work properly in both 5.x and 6.x
Also of possible interest: http://search.cpan.org/~sbeck/Date-Manip/lib/Date/Manip/Problems.pod
Attachments (1)
Change History (4)
Changed 14 years ago by
| Attachment: | weather.patch added |
|---|
comment:1 Changed 14 years ago by
| Owner: | changed from Isaac Richards to beirdo |
|---|---|
| Status: | new → assigned |
comment:2 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:3 Changed 14 years ago by
| Milestone: | unknown → 0.24 |
|---|
(In [25140]) Changed use of "today" in uses of Date::Manip to use "now" for compatibility reasons. Applied patch supplied by mrand@….
Closes #8466