Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#8589 closed defect (fixed)
Recordings are nolonger identified as 720p or 1080i/p since the ProgramInfo refactor.
Reported by: | Owned by: | robertm | |
---|---|---|---|
Priority: | trivial | Milestone: | 0.24 |
Component: | MythTV - Recording | Version: | Master Head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
Changes in mythtv/libs/libmyth/programinfo.cpp during the ProgramInfo? refactor r24694 removed funtionality to identify a recording as 1080i/p or 720p.
Change History (13)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Sorry the SQL output came out horrible.
+--------+---------------------+------------+-----------+ | chanid | starttime | title | videoprop | +--------+---------------------+------------+-----------+ | 2804 | 2010-05-03 22:01:00 | CSI: Miami | HDTV,1080 | | 2804 | 2010-05-05 22:00:00 | CSI: NY | HDTV,720 | | 2804 | 2010-05-10 22:01:00 | CSI: Miami | HDTV,1080 | | 2804 | 2010-05-12 22:00:00 | CSI: NY | HDTV,1080 | | 2814 | 2010-05-16 18:00:00 | CSI: Miami | HDTV,1080 | | 2814 | 2010-05-16 23:00:00 | CSI: Miami | HDTV | | 2804 | 2010-05-17 22:01:00 | CSI: Miami | HDTV | | 2804 | 2010-05-19 22:00:00 | CSI: NY | HDTV | | 2814 | 2010-05-23 18:00:00 | CSI: Miami | HDTV | +--------+---------------------+------------+-----------+
comment:3 Changed 14 years ago by
Status: | new → assigned |
---|
comment:4 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|
comment:5 Changed 14 years ago by
It looks like this is supposed to be handled by the SaveResolutionProperty?() call in TVRec::TeardownRecorder?(). Not sure yet why it is not working.
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:7 Changed 14 years ago by
In the process of testing this patch I have discovered a small problem with the fix. The SQL query that is updating the flags in the recordedprogram table is matching on STARTTIME == recstartts.
In cases where the recording has a preroll or start early rule the recstartts time will not match the STARTTIME field in the recordedprogram table and the update will not occur.
Changing the binding for :STARTTIME to be startts instead of recstartts fixed the issue for me.
comment:8 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
comment:9 Changed 14 years ago by
Status: | new → assigned |
---|
comment:10 Changed 14 years ago by
Owner: | changed from danielk to robertm |
---|
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [26358]) Restore the original behavior of the markup query SQL to use startts as the key, not recstartts-- since the pginfo refactor and subsequent restoration of this functionality, setting the video flags was failing if the recording had preroll. This should restore reliable behavior to all recordings. Fixes #8589.
There is a specific section of code that was removed that in the programinfo refactor that never had a similar function added to replace the functionality of the removed code.
This is the section that was removed
This is the section that was added.
Looking at these it seems that the code to set the value as 720 or 1080 was removed and no replacement was added.
Here is a select statement from my database from the recordedprogram table
select chanid,starttime,title,videoprop from recordedprogram where title like 'CSI%' order by starttime;
As you can see the 720/1080 is nolonger being sent to the videoprop column in the table since the update I did in between the 2 recordings from May 16th.