Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#8818 closed patch (fixed)
i18n themestring update for 0.24
Reported by: | Owned by: | stuartm | |
---|---|---|---|
Priority: | minor | Milestone: | 0.24 |
Component: | Translations | Version: | Master Head |
Severity: | medium | Keywords: | themestring update i18n |
Cc: | Ticket locked: | no |
Description
The themestring update in r25760 unfortunately added ~400 unwanted strings, by including strings from the plugins both in the themestrings.h files of the plugins (correct), as well as in the themestrings.h of mythfrontend (wrong). Search for "Humidity" or "ROM Name" in trunk/mythtv/themes/themestrings.h to confirm this.
The attached patch updates the themestringtool run script for current trunk/0.24. It should be sufficient to just run the script afterwards to generate the themestrings for mythfrontend and the plugins (hopefully without any errors).
The patch is mostly cosmetic changes to remove unwanted error messages and make it more user friendly:
- Add a short introduction in the beginning of the script, describing its purpose.
- Add a check to see if the themestringstool has been compiled before trying to do anything.
- Remove the weather.com maps.xml hack, since it has been entirely removed from mythweather in r25182.
- Remove (comment out) zoneminder-ui.xml as it didn't exist for 0.23, still doesn't exist in trunk and doesn't seem to be receiving any love at all.
- Remove (comment out) the call of emacs at the end of the script...not everyone is using emacs and/or has the tool installed :)
Attachments (3)
Change History (15)
Changed 14 years ago by
Attachment: | update_themestringstool_run_script.patch added |
---|
comment:1 Changed 14 years ago by
Status: | new → infoneeded_new |
---|
comment:2 Changed 14 years ago by
Yes, 415 strings should get removed from trunk/mythtv/themes/themestrings.h...but this is not due to the my changes, this should be the same with the old run.sh script. The update just removes all the errors. I just do a clean checkout of trunk, cd themestringstool, qmake, make, ./run.sh.
comment:3 Changed 14 years ago by
Sorry Kenni, it doesn't do the job. Unmodified trunk here gets no changes with or without your patched run.sh script.
comment:4 Changed 14 years ago by
Status: | infoneeded_new → new |
---|
comment:5 Changed 14 years ago by
Owner: | changed from Reynaldo H. Verdejo Pinochet to stuartm |
---|---|
Status: | new → assigned |
comment:6 Changed 14 years ago by
Are you running the script with root privileges? That would ignore the "remove read permissions" logic of the script. I just tested it, running as a regular user gives me 703 strings, while root gives me 1115 strings. I'll update the patch with a root-user-check in a few minutes.
Changed 14 years ago by
Attachment: | update_themestringstool_run_script_v2.patch added |
---|
Updated patch
comment:8 Changed 14 years ago by
comment:9 Changed 14 years ago by
Status: | assigned → infoneeded |
---|
Kenni,
I build as root. If you'd like to attach the theme string diffs, I am happy to apply them.
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | infoneeded → closed |
comment:12 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|
Hi Kenni,
Unfortunately, on my system, running this updated script changes nothing. Were you expecting translations to move?