Opened 18 years ago

Closed 18 years ago

#994 closed defect (invalid)

incorrect usage of type "char"

Reported by: cardoe@… Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords: PPC
Cc: Ticket locked: no

Description

While x86 automatically sets type "char" to "signed char", other ARCHes such as PPC set it to "unsigned char". So there's a data consistency problem when passing in negative values when using type "char". I changed the types to "signed char", to clear up the problem on all ARCHes.

Attachments (1)

mythtv-0.19_pre8554-chanutil-schar.patch​ (1.1 KB) - added by cardoe@… 18 years ago.
mythtv-0.19_pre8554-chanutil-schar.patch

Download all attachments as: .zip

Change History (6)

Changed 18 years ago by cardoe@…

Attachment: mythtv-0.19_pre8554-chanutil-schar.patch​ added

mythtv-0.19_pre8554-chanutil-schar.patch

comment:1 Changed 18 years ago by danielk

Owner: changed from Isaac Richards to danielk

comment:2 Changed 18 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [8565]) Closes #994.

This fixes a compiler warning on PPC platform for a DVB function. This does not effect the code on x86[-64] platforms.

comment:3 Changed 18 years ago by danielk

(In [8692]) Fix #1081, by reverting patch for #994. References #994.

comment:4 Changed 18 years ago by anonymous

Milestone: 0.19 → 0.20
Resolution: fixed
Status: closed → reopened

Cardoe, can you look at this again? It looks like the fix for PPC broke DVB scanning on x86 systems.

comment:5 Changed 18 years ago by danielk

Resolution: → invalid
Status: reopened → closed

Submitter did not reply to January request for fix to patch, marking invald.

Note: See TracTickets for help on using tickets.